IRecursiveParent.Children returns a collection instead of IEnumerable

AArnott · AArnott · commit 2877398a99e5 · 2016-07-04T07:10:09.000-06:00
diff --git a/src/ImmutableObjectGraph.Generation/CodeGen+EnumerableRecursiveParentGen.cs b/src/ImmutableObjectGraph.Generation/CodeGen+EnumerableRecursiveParentGen.cs
@@ -115,10 +115,10 @@ private void ImplementRecursiveParentInterface()
                 // this.Children;
                 var thisDotChildren = Syntax.ThisDot(SyntaxFactory.IdentifierName(this.generator.applyToMetaType.RecursiveField.Name.ToPascalCase()));
 
-                // System.Collections.Generic.IEnumerable<IRecursiveType> IRecursiveParent.Children
+                // System.Collections.Generic.IReadOnlyCollection<IRecursiveType> IRecursiveParent.Children
                 this.innerMembers.Add(
                     SyntaxFactory.PropertyDeclaration(
-                        Syntax.GetTypeSyntax(typeof(IEnumerable<IRecursiveType>)),
+                        Syntax.GetTypeSyntax(typeof(IReadOnlyCollection<IRecursiveType>)),
                         nameof(IRecursiveParent.Children))
                     .WithExplicitInterfaceSpecifier(SyntaxFactory.ExplicitInterfaceSpecifier(Syntax.GetTypeSyntax(typeof(IRecursiveParent))))
                     .WithExpressionBody(SyntaxFactory.ArrowExpressionClause(thisDotChildren))
diff --git a/src/ImmutableObjectGraph.Generation/CodeGen+RootedStructGen.cs b/src/ImmutableObjectGraph.Generation/CodeGen+RootedStructGen.cs
@@ -743,8 +743,8 @@ protected MethodDeclarationSyntax CreateParentedNodeMethod()
             protected PropertyDeclarationSyntax[] CreateChildrenProperties()
             {
                 return new PropertyDeclarationSyntax[] {
-                    // IEnumerable<IRecursiveType> IRecursiveParent.Children => this.greenNode.Children;
-                    SyntaxFactory.PropertyDeclaration(Syntax.IEnumerableOf(Syntax.GetTypeSyntax(typeof(IRecursiveType))), nameof(IRecursiveParent.Children))
+                    // IReadOnlyCollection<IRecursiveType> IRecursiveParent.Children => this.greenNode.Children;
+                    SyntaxFactory.PropertyDeclaration(Syntax.IReadOnlyCollectionOf(Syntax.GetTypeSyntax(typeof(IRecursiveType))), nameof(IRecursiveParent.Children))
                         .WithExplicitInterfaceSpecifier(SyntaxFactory.ExplicitInterfaceSpecifier(Syntax.GetTypeSyntax(typeof(IRecursiveParent))))
                         .WithExpressionBody(SyntaxFactory.ArrowExpressionClause(
                             SyntaxFactory.MemberAccessExpression(
diff --git a/src/ImmutableObjectGraph/IRecursiveCollection.cs b/src/ImmutableObjectGraph/IRecursiveCollection.cs
@@ -13,7 +13,7 @@ public interface IRecursiveType {
 	}
 
 	public interface IRecursiveParent : IRecursiveType {
-		IEnumerable<IRecursiveType> Children { get; }
+		IReadOnlyCollection<IRecursiveType> Children { get; }
 
 		ParentedRecursiveType<IRecursiveParent<IRecursiveType>, IRecursiveType> GetParentedNode(IdentityFieldType identity);
 	}

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ public interface IRecursiveType {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`public interface IRecursiveParent : IRecursiveType {`
`16`		`- IEnumerable<IRecursiveType> Children { get; }`
	`16`	`+ IReadOnlyCollection<IRecursiveType> Children { get; }`
`17`	`17`
`18`	`18`	`ParentedRecursiveType<IRecursiveParent<IRecursiveType>, IRecursiveType> GetParentedNode(IdentityFieldType identity);`
`19`	`19`	`}`