Skip to content

Commit 5548c58

Browse files
committed
remove these tests as per @gobbleturk
1 parent 8606de1 commit 5548c58

1 file changed

Lines changed: 0 additions & 20 deletions

File tree

tests/unit/configs_value_test.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -126,26 +126,6 @@ def test_llama3_tokenizer_correction(self):
126126
config = pyconfig.initialize(argv)
127127
self.assertEqual(config.tokenizer_type, "tiktoken")
128128

129-
def test_abort_on_nan_loss_defaults_and_cli_override(self):
130-
"""Tests abort_on_nan_loss default from base.yml and CLI override parsing."""
131-
default_cfg = pyconfig.initialize(["", _BASE_CONFIG_PATH, "run_name=test_default_abort_nan"])
132-
self.assertEqual(default_cfg.abort_on_nan_loss, True)
133-
134-
cli_cfg = pyconfig.initialize(
135-
["", _BASE_CONFIG_PATH, "run_name=test_cli_abort_nan", "abort_on_nan_loss=False"]
136-
)
137-
self.assertEqual(cli_cfg.abort_on_nan_loss, False)
138-
139-
def test_abort_on_inf_loss_defaults_and_cli_override(self):
140-
"""Tests abort_on_inf_loss default from base.yml and CLI override parsing."""
141-
default_cfg = pyconfig.initialize(["", _BASE_CONFIG_PATH, "run_name=test_default_abort_inf"])
142-
self.assertEqual(default_cfg.abort_on_inf_loss, True)
143-
144-
cli_cfg = pyconfig.initialize(
145-
["", _BASE_CONFIG_PATH, "run_name=test_cli_abort_inf", "abort_on_inf_loss=False"]
146-
)
147-
self.assertEqual(cli_cfg.abort_on_inf_loss, False)
148-
149129
def test_initialize_pydantic_bad_keys(self):
150130
"""Test that `pydantic.ValidationError` is raised on keys not in MaxTextConfig"""
151131
with self.assertRaises(ValueError):

0 commit comments

Comments
 (0)