add tests for coverage

Author: guilyx

jupyddl/automated_planner.py

@@ -69,9 +69,6 @@ def available_actions(self, state):
         except (RuntimeError, TypeError, NameError):
             self.logger.warning("Runtime, Type or Name error occured when fetching available action from state" + str(state))
             return []
-        else:
-            self.logger.warning("An error occured when fetching available action from state" + str(state))
-            return []
 
     def satisfies(self, asserted_state, state):
         return self.pddl.satisfy(asserted_state, state, self.domain)[0]
@@ -144,7 +141,7 @@ def astar_best_first_search(self, heuristic_key="basic/goal_count"):
             heuristic = DeleteRelaxationHeuristic(self, heuristic_key)
         else:
             logging.fatal("Not yet implemented")
-            exit()
+            return [], 0, 0
         astar = AStarBestFirstSearch(self, heuristic.compute)
         last_node, total_time, opened_nodes = astar.search()
         path = self.__retrace_path(last_node)

tests/test_basic_astar.py

@@ -34,3 +34,17 @@ def test_astar_path_length():
     )
     path, _, _ = apla.astar_best_first_search()
     assert len(path) > 0
+
+def test_astar_path_no_path():
+    apla = AutomatedPlanner(
+        "pddl-examples/vehicle/domain.pddl", "pddl-examples/vehicle/problem.pddl"
+    )
+    path, _, _ = apla.astar_best_first_search()
+    assert len(path) == 0
+
+def test_astar_path_no_heuristic():
+    apla = AutomatedPlanner(
+        "pddl-examples/flip/domain.pddl", "pddl-examples/flip/problem.pddl"
+    )
+    p, t, c = apla.astar_best_first_search(heuristic_key="idontexist")
+    assert not p and not t and not c

tests/test_basic_search.py

@@ -57,3 +57,28 @@ def test_search_astar_delete_relaxation():
     res = astar.search()  # Goal, computation_time, opened_nodes(in this order)
     assert res[1] != 0  # Assert that it took time to compute
     assert res[-1] > 0  # Assert that it visited at least one node
+
+def test_search_getter_costs():
+    apla = AutomatedPlanner(
+        "pddl-examples/tsp/domain.pddl", "pddl-examples/tsp/problem.pddl"
+    )
+    bfs = BreadthFirstSearch(apla)
+    path, _, _ = bfs.search()  # Path, computation time, opened nodes
+    plan = apla.get_actions_from_path(path)
+    state_plan = apla.get_state_def_from_path(path)
+
+    assert path and plan and state_plan
+
+def test_search_getter_no_costs():
+    apla = AutomatedPlanner(
+        "pddl-examples/cargo/domain.pddl", "pddl-examples/cargo/problem.pddl"
+    )
+    bfs = BreadthFirstSearch(apla)
+    path, _, _ = bfs.search()  # Path, computation time, opened nodes
+    plan = apla.get_actions_from_path(path)
+    state_plan = apla.get_state_def_from_path(path)
+
+    assert path and plan and state_plan
+
+
+

tests/test_heuristics.py

@@ -18,6 +18,7 @@ def test_zero_heuristic():
     apla = AutomatedPlanner(
         "pddl-examples/dinner/domain.pddl", "pddl-examples/dinner/problem.pddl"
     )
+    apla.display_available_heuristics()
     heuristic = hs.BasicHeuristic(apla, "basic/zero")
     h = heuristic.compute(apla.initial_state)
     assert h == 0
@@ -27,6 +28,7 @@ def test_goal_count_heuristic():
     apla = AutomatedPlanner(
         "pddl-examples/dinner/domain.pddl", "pddl-examples/dinner/problem.pddl"
     )
+    apla.display_available_heuristics()
     heuristic = hs.BasicHeuristic(apla, "basic/goal_count")
     h = heuristic.compute(apla.initial_state)
     assert h != 0
@@ -36,6 +38,7 @@ def test_delete_relaxation_add_heuristic():
     apla = AutomatedPlanner(
         "pddl-examples/tsp/domain.pddl", "pddl-examples/tsp/problem.pddl"
     )
+    apla.display_available_heuristics()
     heuristic = hs.DeleteRelaxationHeuristic(apla, "delete_relaxation/h_max")
     h = heuristic.compute(apla.initial_state)
     assert h != 0

tests/test_setup.py

@@ -0,0 +1,2 @@
+def test_setup():
+    import setup