Support numbers in REPLACE() to fix #1455 (#2282)

Co-authored-by: NmN03jain <njain5587@gmail.com>
Co-authored-by: Naman Jain <90062260+NmN03jain@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

Author: 3 people

src/40select.js

@@ -139,11 +139,6 @@ yy.Select = class Select {
 	 Select statement in expression
 	 */
 	toJS(context) {
-		//	console.log('Expression',this);
-		//	if(this.expression.reduced) return 'true';
-		//	return this.expression.toJS(context, tableid, defcols);
-		// console.log('Select.toJS', 81, this.queriesidx);
-		//	var s = 'this.queriesdata['+(this.queriesidx-1)+'][0]';
 		var s =
 			'alasql.utils.flatArray(this.queriesfn[' +
 			(this.queriesidx - 1) +

src/55functions.js

@@ -454,7 +454,9 @@ Object.keys(alasql._aggrOriginal).forEach(function (k) {
 
 // String functions
 stdfn.REPLACE = function (target, pattern, replacement) {
-	return (target || '').split(pattern).join(replacement);
+	return String(target ?? '')
+		.split(String(pattern ?? ''))
+		.join(String(replacement ?? ''));
 };
 
 // This array is required for fast GUID generation

src/alasqlparser.jison

@@ -342,6 +342,7 @@ SETS                                        	return 'SET'
 %left DOT ARROW EXCLAMATION
 %left TILDA
 %left SHARP
+
 %left BARBAR
 
 %ebnf

test/test1455.js

@@ -0,0 +1,31 @@
+if (typeof exports === 'object') {
+	var assert = require('assert');
+	var alasql = require('..');
+}
+
+describe('Test 1455 - REPLACE function', function () {
+	it('A) REPLACE with string target', function () {
+		var res = alasql("SELECT REPLACE('123', '2', '_')");
+		assert.deepEqual(res, [{["REPLACE('123','2','_')"]: '1_3'}]);
+	});
+
+	it('B) REPLACE with numeric target (converted to string)', function () {
+		var res = alasql("SELECT REPLACE(123, '2', '_')");
+		assert.deepEqual(res, [{["REPLACE(123,'2','_')"]: '1_3'}]);
+	});
+
+	it('C) Both string and numeric in same query', function () {
+		var res = alasql("SELECT REPLACE('123', '2', '_'), REPLACE(123, '2', '_')");
+		assert.deepEqual(res, [
+			{
+				["REPLACE('123','2','_')"]: '1_3',
+				["REPLACE(123,'2','_')"]: '1_3',
+			},
+		]);
+	});
+
+	it('D) REPLACE with numeric search and replacement', function () {
+		var res = alasql('SELECT REPLACE(12321, 2, 9)');
+		assert.deepEqual(res, [{['REPLACE(12321,2,9)']: '19391'}]);
+	});
+});