[O2B-1502] minor changes, processed feedback

Author: Houwie7000

lib/public/components/Filters/LhcFillsFilter/stableBeamFilter.js

@@ -24,18 +24,18 @@ import { radioButton } from '../../common/form/inputs/radioButton.js';
  */
 export const toggleStableBeamOnlyFilter = (stableBeamFilterModel, radioButtonMode = false) => {
     const name = 'stableBeamsOnlyRadio';
-    const label1 = 'OFF';
-    const label2 = 'ON';
+    const labelOff = 'OFF';
+    const labelOn = 'ON';
     if (radioButtonMode) {
         return h('.form-group-header.flex-row.w-100', [
             radioButton({
-                label: label1,
+                label: labelOff,
                 isChecked: !stableBeamFilterModel.isStableBeamsOnly(),
                 action: () => stableBeamFilterModel.setStableBeamsOnly(false),
                 name: name,
             }),
             radioButton({
-                label: label2,
+                label: labelOn,
                 isChecked: stableBeamFilterModel.isStableBeamsOnly(),
                 action: () => stableBeamFilterModel.setStableBeamsOnly(true),
                 name: name,

lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js

@@ -11,6 +11,7 @@
  * or submit itself to any jurisdiction.
  */
 
+import { buildUrl } from '/js/src/index.js';
 import { FilteringModel } from '../../../components/Filters/common/FilteringModel.js';
 import { StableBeamFilterModel } from '../../../components/Filters/LhcFillsFilter/StableBeamFilterModel.js';
 import { OverviewPageModel } from '../../../models/OverviewModel.js';
@@ -58,7 +59,7 @@ export class LhcFillsOverviewModel extends OverviewPageModel {
      * @inheritDoc
      */
     getRootEndpoint() {
-        return '/api/lhcFills';
+        return buildUrl('/api/lhcFills', { filter: this.filteringModel.normalized });
     }
 
     /**
@@ -67,7 +68,6 @@ export class LhcFillsOverviewModel extends OverviewPageModel {
     async getLoadParameters() {
         return {
             ...await super.getLoadParameters(),
-            ...{ filter: this.filteringModel.normalized },
         };
     }
 

test/public/lhcFills/overview.test.js

@@ -266,15 +266,14 @@ module.exports = () => {
     });
 
     it('should successfully display filter elements', async () => {
-        const filterSBExpect = { selector: '.w-30', value: 'Stable Beams Only' };
+        const filterSBExpect = { selector: '.stableBeams-filter .w-30', value: 'Stable Beams Only' };
         await goToPage(page, 'lhc-fill-overview');
         // Open the filtering panel
         await openFilteringPanel(page);
         await expectInnerText(page, filterSBExpect.selector, filterSBExpect.value);
     });
 
-
-     it('should successfully un-apply Stable Beam filter menu', async () => {
+    it('should successfully un-apply Stable Beam filter menu', async () => {
         const filterButtonSBOnlySelector= '#stableBeamsOnlyRadioOFF';
         await goToPage(page, 'lhc-fill-overview');
         await waitForTableLength(page, 5);