Skip to content

Commit 4868232

Browse files
committed
add diaply for debugging
1 parent 36a7615 commit 4868232

4 files changed

Lines changed: 12 additions & 4 deletions

File tree

lib/database/repositories/QcFlagRepository.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ class QcFlagRepository extends Repository {
6262
gaq_periods.run_number AS runNumber,
6363
gaq_periods.\`from\` AS \`from\`,
6464
gaq_periods.\`to\` AS \`to\`,
65-
group_concat(qcf.id) AS contributingFlagIds
65+
group_concat(qcf.id) AS contributingFlagIds,
66+
gaq_periods.coverage_ratio AS coverage_ratio
6667
6768
FROM quality_control_flags AS qcf
6869
INNER JOIN quality_control_flag_effective_periods AS qcfep
@@ -93,12 +94,14 @@ class QcFlagRepository extends Repository {
9394
from,
9495
to,
9596
contributingFlagIds,
97+
coverage_ratio,
9698
}) => ({
9799
dataPassId,
98100
runNumber,
99101
from: from?.getTime(),
100102
to: to?.getTime(),
101103
contributingFlagIds: contributingFlagIds.split(',').map((id) => parseInt(id, 10)),
104+
coverageRatio: parseFloat(coverage_ratio ?? '0'),
102105
}));
103106
}
104107

lib/public/views/QcFlags/ActiveColumns/gaqFlagsActiveColumns.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,10 @@ export const createGaqFlagsActiveColumns = (
124124
format: (_, qcFlag) => formatQcFlagEnd(qcFlag),
125125
classes: 'w-10',
126126
},
127+
coverageRatio: {
128+
name: 'Coverage Ratio',
129+
visible: true,
130+
},
127131
...Object.fromEntries(gaqDetectors.map(({ id: detectorId, name: detectorName }) => [
128132
`${detectorName}-flag`,
129133
{

lib/server/services/qualityControlFlag/GaqService.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,12 @@ class GaqService {
9595
contributingFlagIds,
9696
from,
9797
to,
98+
coverageRatio,
9899
}) => ({
99100
from,
100101
to,
101102
contributingFlags: contributingFlagIds.map((id) => idToFlag[id]),
103+
coverageRatio,
102104
}));
103105
}
104106
}

test/lib/server/services/qualityControlFlag/QcFlagService.test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ const getEffectivePeriodsOfQcFlag = async (flagId) => (await QcFlagEffectivePeri
4343
const t = (timeString) => new Date(`2024-07-16 ${timeString}`).getTime();
4444

4545
const goodFlagTypeId = 3;
46+
const badPidFlagTypeId = 12;
47+
const limitedAccMCTypeId = 5;
4648

4749
const qcFlagWithId1 = {
4850
id: 1,
@@ -1601,9 +1603,6 @@ module.exports = () => {
16011603
const t = (timeString) => new Date(`2024-07-10 ${timeString}`).getTime();
16021604

16031605
const relations = { user: { roles: ['admin'], externalUserId: 456 } };
1604-
const goodFlagTypeId = 3;
1605-
const badPidFlagTypeId = 12;
1606-
const limitedAccMCTypeId = 5;
16071606

16081607
it('should successfully get GAQ flags', async () => {
16091608
const dataPassId = 3;

0 commit comments

Comments
 (0)