Skip to content

Commit 5a5e830

Browse files
author
Guust
committed
add runs filter to the filteringmodel
1 parent 93b3291 commit 5a5e830

2 files changed

Lines changed: 23 additions & 6 deletions

File tree

lib/public/views/Logs/ActiveColumns/logsActiveColumns.js

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import { iconCommentSquare, iconPaperclip } from '/js/src/icons.js';
1616

1717
import { authorFilter } from '../../../components/Filters/LogsFilter/author/authorFilter.js';
1818
import createdFilter from '../../../components/Filters/LogsFilter/created.js';
19-
import runsFilter from '../../../components/Filters/LogsFilter/runs.js';
2019
import { formatTimestamp } from '../../../utilities/formatting/formatTimestamp.js';
2120
import { frontLink } from '../../../components/common/navigation/frontLink.js';
2221
import { frontLinks } from '../../../components/common/navigation/frontLinks.js';
@@ -28,6 +27,7 @@ import { environmentFilter } from '../../../components/Filters/LogsFilter/enviro
2827
import { formatLhcFillsList } from '../../LhcFills/format/formatLhcFillsList.js';
2928
import { lhcFillsFilter } from '../../../components/Filters/LogsFilter/lhcFill.js';
3029
import { formatTagsList } from '../../Tags/format/formatTagsList.js';
30+
import { rawTextFilter } from '../../../components/Filters/common/filters/rawTextFilter.js';
3131

3232
/**
3333
* A method to display a small and simple number/icon collection as a column
@@ -108,11 +108,11 @@ export const logsActiveColumns = {
108108
* @param {FilteringModel} logOverviewModel.filteringModel filtering model
109109
* @return {Component} the filter component
110110
*/
111-
filter: ({ filteringModel }) => textFilter(
111+
filter: ({ filteringModel }) => rawTextFilter(
112112
filteringModel.get('contentFilter'),
113113
{
114114
id: 'contentFilterText',
115-
class: 'w-75 mt1',
115+
classes: ['w-75', 'mt1'],
116116
},
117117
),
118118
},
@@ -168,7 +168,22 @@ export const logsActiveColumns = {
168168
sortable: true,
169169
size: 'w-15',
170170
format: formatRunsList,
171-
filter: runsFilter,
171+
172+
/**
173+
* Runs filter component
174+
*
175+
* @param {LogsOverviewModel} logOverviewModel the logs overview model
176+
* @param {FilteringModel} logOverviewModel.filteringModel filtering model
177+
* @return {Component} the filter component
178+
*/
179+
filter: ({ filteringModel }) => rawTextFilter(
180+
filteringModel.get('run'),
181+
{
182+
id: 'runsFilterText',
183+
classes: ['w-75', 'mt1'],
184+
placeholder: 'e.g. 553203, 553221, ...',
185+
},
186+
),
172187
balloon: true,
173188
profiles: [profiles.none, 'embeded'],
174189
},

lib/public/views/Logs/Overview/LogsOverviewModel.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ export class LogsOverviewModel extends Observable {
4242
titleFilter: new RawTextFilterModel(),
4343
contentFilter: new RawTextFilterModel(),
4444
listingTagsFilterModel: new TagFilterModel(tagsProvider.items$),
45+
run: new RawTextFilterModel(),
4546
});
4647

4748
this._filteringModel.observe(() => this._applyFilters());
@@ -357,6 +358,7 @@ export class LogsOverviewModel extends Observable {
357358
const contentFilter = this._filteringModel.get('contentFilter');
358359
const authorFilter = this._filteringModel.get('authorFilter');
359360
const listingTagsFilterModel = this._filteringModel.get('listingTagsFilterModel');
361+
const run = this._filteringModel.get('run');
360362

361363
return {
362364
...!titleFilter.isEmpty && {
@@ -380,8 +382,8 @@ export class LogsOverviewModel extends Observable {
380382
'filter[tags][values]': listingTagsFilterModel.selected.join(),
381383
'filter[tags][operation]': listingTagsFilterModel.combinationOperator,
382384
},
383-
...this.runFilterValues.length > 0 && {
384-
'filter[run][values]': this.runFilterValues.join(),
385+
...!run.isEmpty && {
386+
'filter[run][values]': run.normalized,
385387
'filter[run][operation]': this.runFilterOperation.toLowerCase(),
386388
},
387389
...this.environmentFilterValues.length > 0 && {

0 commit comments

Comments
 (0)