Improve naming

Author: martinboulais

lib/server/services/qualityControlFlag/QcFlagService.js

@@ -537,20 +537,19 @@ class QcFlagService {
      * @throws {BadParameterError}
      */
     _prepareQcFlagPeriod(timestamps, targetRun) {
-        const { qcTimeStart, qcTimeEnd } = targetRun;
-        const runStart = qcTimeStart?.getTime();
-        const runEnd = qcTimeEnd?.getTime();
+        const qcTimeStart = targetRun.qcTimeStart?.getTime();
+        const qcTimeEnd = targetRun.qcTimeEnd?.getTime();
 
         const { from, to } = timestamps;
 
         if (from && to && from >= to) {
             throw new BadParameterError('Parameter "to" timestamp must be greater than "from" timestamp');
         }
 
-        const isFromOutOfRange = from && (runStart && from < runStart || runEnd && runEnd <= from);
-        const isToOutOfRange = to && (runStart && to <= runStart || runEnd && runEnd < to);
+        const isFromOutOfRange = from && (qcTimeStart && from < qcTimeStart || qcTimeEnd && qcTimeEnd <= from);
+        const isToOutOfRange = to && (qcTimeStart && to <= qcTimeStart || qcTimeEnd && qcTimeEnd < to);
         if (isFromOutOfRange || isToOutOfRange) {
-            throw new BadParameterError(`Given QC flag period (${from}, ${to}) is out of run (${runStart}, ${runEnd}) period`);
+            throw new BadParameterError(`Given QC flag period (${from}, ${to}) is out of run (${qcTimeStart}, ${qcTimeEnd}) period`);
         }
 
         return { from, to };