Fix glitch in flags chart display height (#1880)

Author: martinboulais

lib/public/views/QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js

@@ -89,7 +89,7 @@ export const QcFlagsForDataPassOverviewPage = ({
             }),
             mergeRemoteData([remoteQcFlags, remoteRun])
                 .match({
-                    Success: ([flags, run]) => h('#qc-flags-chart-component', qcFlagsChartComponent(flags, run)),
+                    Success: ([flags, run]) => qcFlagsChartComponent(flags, run),
                     Failure: () => null,
                     Loading: () => spinner({ size: 2, absolute: false }),
                     NotAsked: () => errorAlert([{ title: 'No data', detail: 'No QC flags or run data was asked for' }]),

lib/public/views/QcFlags/qcFlagsVisualization/qcFlagsChartComponent.js

@@ -26,7 +26,7 @@ import { h } from '/js/src/index.js';
  */
 export const qcFlagsChartComponent = (flags, run) => {
     if ((run.qcTimeStart ?? null) === null || (run.qcTimeEnd ?? null) === null) {
-        return h('h4.pv3', 'Missing run start or end, no QC flags chart');
+        return h('h4#qc-flags-chart-component-error.pv3', 'Missing run start or end, no QC flags chart');
     }
 
     /**

test/public/qcFlags/detailsForDataPass.test.js

@@ -168,11 +168,11 @@ module.exports = () => {
     it('should successfully display a message instead of QC flags chart when run is missing boundaries', async () => {
         await navigateToRunsPerDataPass(page, 1, 4, 5);
         await waitForNavigation(page, () => pressElement(page, '#row105-CPV-text a'));
-        await expectInnerText(page, '#qc-flags-chart-component', 'Missing run start or end, no QC flags chart');
+        await expectInnerText(page, '#qc-flags-chart-component-error', 'Missing run start or end, no QC flags chart');
 
         await page.goBack();
 
         await waitForNavigation(page, () => pressElement(page, '#row100-CPV-text a'));
-        await expectInnerText(page, '#qc-flags-chart-component', 'Missing run start or end, no QC flags chart');
+        await expectInnerText(page, '#qc-flags-chart-component-error', 'Missing run start or end, no QC flags chart');
     });
 };