[O2B-1569] Getting all runs with effective qc flags query needs to be split (#2110)

- improved loading times of page runs-per-data-pass and prevent memory crash of the process due to heavy SQL queries
- use sequalize separate function to split big SQL join queries

Author: graduta

lib/usecases/run/GetAllRunsUseCase.js

@@ -340,13 +340,16 @@ class GetAllRunsUseCase {
             }
 
             if (dataPassIds) {
+                const whereDataPassIds = dataPassIds.length === 1
+                    ? { id: { [Op.eq]: dataPassIds[0] } }
+                    : { id: { [Op.in]: dataPassIds } };
                 const runNumbers = (await RunRepository.findAll({
                     attributes: ['runNumber'],
                     raw: true,
                     include: [
                         {
                             association: 'dataPass',
-                            where: { id: { [Op.in]: dataPassIds } },
+                            where: whereDataPassIds,
                         },
                     ],
                 })).map(({ runNumber }) => runNumber);
@@ -529,15 +532,17 @@ class GetAllRunsUseCase {
             const qcFlagsAssociationDef = {
                 association: 'qcFlags',
                 required: false,
+                separate: true,
+                order: [['from', 'ASC']],
                 where: { [Op.and]: [
                     { deleted: false },
                     sequelize.literal(`(
-                        \`qcFlags->detector\`.\`type\` not in (${detectorTypesOfNoneExportableAnonymousFlagsEscaped})
-                        OR \`qcFlags->createdBy\`.\`name\` != 'Anonymous'
+                        \`detector\`.\`type\` not in (${detectorTypesOfNoneExportableAnonymousFlagsEscaped})
+                        OR \`createdBy\`.\`name\` != 'Anonymous'
                     )`),
                 ] },
                 include: [
-                    { association: 'effectivePeriods', required: true },
+                    { association: 'effectivePeriods', required: true, separate: true },
                     { association: 'flagType' },
                     { association: 'detector', required: true },
                     { association: 'createdBy' },
@@ -553,13 +558,7 @@ class GetAllRunsUseCase {
             } else {
                 qcFlagsAssociationDef.include.push({ association: 'dataPasses', required: false });
                 qcFlagsAssociationDef.include.push({ association: 'simulationPasses', required: false });
-                qcFlagsAssociationDef.where[Op.or] = [
-                    { '$qcFlags.id$': null },
-                    {
-                        '$qcFlags.dataPasses.id$': null,
-                        '$qcFlags.simulationPasses.id$': null,
-                    },
-                ];
+                qcFlagsAssociationDef.where[Op.and].push(sequelize.literal('(`dataPasses`.`id` IS NULL AND `simulationPasses`.`id` IS NULL)'));
 
                 fetchQueryBuilder.include(qcFlagsAssociationDef);
             }

test/public/runs/runsPerDataPass.overview.test.js

@@ -407,7 +407,7 @@ module.exports = () => {
         expect(exportContent.trim()).to.be.eql([
             'runNumber;CPV;VTX',
             '108;"";""',
-            '107;"Good (from: 1565290800000 to: 1565359260000) | Limited Acceptance MC Reproducible (from: 1565269140000 to: 1565290800000)";""',
+            '107;"Limited Acceptance MC Reproducible (from: 1565269140000 to: 1565290800000) | Good (from: 1565290800000 to: 1565359260000)";""',
             '106;"Limited Acceptance MC Reproducible (from: 1565304200000 to: 1565324200000) | Limited acceptance (from: 1565329200000 to: 1565334200000) | Bad (from: 1565339200000 to: 1565344200000)";"Good (from: 1565269200000 to: 1565304200000) | Good (from: 1565324200000 to: 1565359200000)"',
         ].join('\r\n'));
         fs.unlinkSync(path.resolve(downloadPath, targetFileName));