Cleaning

Author: martinboulais

lib/public/components/common/selection/dropdown/selectionDropdown.js

@@ -30,12 +30,10 @@ const filteredDropdownOptions = (selectionModel, filter, selectorPrefix) => {
      * Display a given option
      *
      * @param {SelectionOption} option the option to display
-     * @param {boolean} checked the current state of the option
-     * @param {function} onChange function called with the option and its new state when the option's state change
      * @param {string} [selectorPrefix] prefix used to generate DOM selectors for the component
      * @return {Component} the option's view
      */
-    const displayOption = (option, checked, onChange, selectorPrefix) => {
+    const displayOption = (option, selectorPrefix) => {
         const selector = option.selector ?? option.value;
 
         return h(
@@ -47,8 +45,8 @@ const filteredDropdownOptions = (selectionModel, filter, selectorPrefix) => {
                     {
                         type: selectionModel.multiple || selectionModel.allowEmpty ? 'checkbox' : 'radio',
                         name: `${selectorPrefix}dropdown-option-${selectionModel.multiple ? selector : 'group'}`,
-                        checked,
-                        onchange: (e) => onChange(option, e.target.checked),
+                        checked: selectionModel.isSelected(option),
+                        onchange: (e) => e.target.checked ? selectionModel.select(option) : selectionModel.deselect(option),
                     },
                 ),
                 option.label || option.value,
@@ -60,28 +58,20 @@ const filteredDropdownOptions = (selectionModel, filter, selectorPrefix) => {
      * Displays the list of available options
      *
      * @param {SelectionOption[]} availableOptions the list of all the available options
-     * @param {function} onChange callback to handle an option state change
      * @return {Component} the options list
      */
-    const optionsList = (availableOptions, onChange) => {
+    const optionsList = (availableOptions) => {
         if (availableOptions.length === 0) {
             return h('.ph2.pv1', h('em', 'No options'));
         }
 
         return availableOptions.map((option) => displayOption(
             option,
-            selectionModel.isSelected(option),
-            onChange,
             selectorPrefix,
         ));
     };
 
-    return h('.dropdown-options', optionsList(
-        filterSelectionOptions(selectionModel.options, filter),
-        (option, state) => {
-            state ? selectionModel.select(option) : selectionModel.deselect(option);
-        },
-    ));
+    return h('.dropdown-options', optionsList(filterSelectionOptions(selectionModel.options, filter)));
 };
 
 /**