fixes

Author: xsalonx

lib/database/repositories/QcFlagRepository.js

@@ -62,8 +62,7 @@ class QcFlagRepository extends Repository {
                 gp.run_number AS runNumber,
                 gp.\`from\` AS \`from\`,
                 gp.\`to\` AS \`to\`,
-                group_concat(qcf.id) AS contributingFlagIds,
-                gp.coverage_ratio AS coverage_ratio
+                group_concat(qcf.id) AS contributingFlagIds
 
             FROM quality_control_flags AS qcf
             INNER JOIN quality_control_flag_effective_periods AS qcfep ON qcf.id = qcfep.flag_id
@@ -93,14 +92,12 @@ class QcFlagRepository extends Repository {
             from,
             to,
             contributingFlagIds,
-            coverage_ratio,
         }) => ({
             dataPassId,
             runNumber,
             from: from?.getTime(),
             to: to?.getTime(),
             contributingFlagIds: contributingFlagIds.split(',').map((id) => parseInt(id, 10)),
-            coverageRatio: parseFloat(coverage_ratio ?? '0'),
         }));
     }
 

lib/public/views/QcFlags/ActiveColumns/gaqFlagsActiveColumns.js

@@ -124,10 +124,6 @@ export const createGaqFlagsActiveColumns = (
         format: (_, qcFlag) => formatQcFlagEnd(qcFlag),
         classes: 'w-10',
     },
-    coverageRatio: {
-        name: 'Coverage Ratio',
-        visible: true,
-    },
     ...Object.fromEntries(gaqDetectors.map(({ id: detectorId, name: detectorName }) => [
         `${detectorName}-flag`,
         {

lib/server/services/qualityControlFlag/GaqService.js

@@ -95,12 +95,10 @@ class GaqService {
             contributingFlagIds,
             from,
             to,
-            coverageRatio,
         }) => ({
             from,
             to,
             contributingFlags: contributingFlagIds.map((id) => idToFlag[id]),
-            coverageRatio,
         }));
     }
 }

test/public/qcFlags/index.js

@@ -28,5 +28,5 @@ module.exports = () => {
     describe('For Simulation Pass Creation Page', ForSimulationPassCreationSuite);
     describe('Details For Data Pass Page', DetailsForDataPassPageSuite);
     describe('Details For Simulation Pass Page', DetailsForSimulationPassPageSuite);
-    describe('GAQ Overview page', GaqOverviewPageSuite);
+    describe('GAQ Overview Page', GaqOverviewPageSuite);
 };