Skip to content

Commit da8ddd5

Browse files
committed
[O2B-1509] Added tests
1 parent 30e7d5f commit da8ddd5

3 files changed

Lines changed: 61 additions & 1 deletion

File tree

test/api/lhcFills.test.js

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -571,6 +571,56 @@ module.exports = () => {
571571
done();
572572
});
573573
});
574+
575+
it('should return 200 and an LHCFill array for schemename filter, full', (done) => {
576+
request(server)
577+
.get('/api/lhcFills?page[offset]=0&page[limit]=15&filter[schemeName]=Single_12b_8_1024_8_2018')
578+
.expect(200)
579+
.end((err, res) => {
580+
if (err) {
581+
done(err);
582+
return;
583+
}
584+
585+
expect(res.body.data).to.have.lengthOf(1);
586+
expect(res.body.data[0].fillNumber).to.equal(6);
587+
588+
done();
589+
});
590+
});
591+
592+
it('should return 200 and an LHCFill array for schemename filter, partial', (done) => {
593+
request(server)
594+
.get('/api/lhcFills?page[offset]=0&page[limit]=15&filter[schemeName]=_1')
595+
.expect(200)
596+
.end((err, res) => {
597+
if (err) {
598+
done(err);
599+
return;
600+
}
601+
602+
expect(res.body.data).to.have.lengthOf(2);
603+
expect(res.body.data[0].fillNumber).to.equal(6);
604+
605+
done();
606+
});
607+
});
608+
609+
it('should return 400 for schemename filter, empty filter', (done) => {
610+
request(server)
611+
.get('/api/lhcFills?page[offset]=0&page[limit]=15&filter[schemeName]=')
612+
.expect(400)
613+
.end((err, res) => {
614+
if (err) {
615+
done(err);
616+
return;
617+
}
618+
619+
expect(res.body.errors[0].title).to.equal('Invalid Attribute');
620+
621+
done();
622+
});
623+
});
574624
});
575625
describe('POST /api/lhcFills', () => {
576626
it('should return 201 if valid data is provided', async () => {

test/lib/usecases/lhcFill/GetAllLhcFillsUseCase.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ module.exports = () => {
6666
})
6767

6868
it('should only contain specified fill numbers, range', async () => {
69-
getAllLhcFillsDto.query = { filter: { bhasStableBeams: true, fillNumbers: '1-3,6' } };
69+
getAllLhcFillsDto.query = { filter: { hasStableBeams: true, fillNumbers: '1-3,6' } };
7070
const { lhcFills } = await new GetAllLhcFillsUseCase().execute(getAllLhcFillsDto);
7171

7272

test/public/lhcFills/overview.test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,4 +350,14 @@ module.exports = () => {
350350
await pressElement(page, filterBeamTypePb_Pb);
351351
await waitForTableLength(page, 2);
352352
});
353+
354+
it('should successfully apply schemename filter', async () => {
355+
const filterSchemenameInputField= '.scheme-name-filter';
356+
await goToPage(page, 'lhc-fill-overview');
357+
await waitForTableLength(page, 5);
358+
// Open the filtering panel
359+
await openFilteringPanel(page);
360+
await fillInput(page, filterSchemenameInputField, 'Single_12b_8_1024_8_2018', ['change']);
361+
await waitForTableLength(page, 1);
362+
});
353363
};

0 commit comments

Comments
 (0)