[core] Meaningful output of TasksDeploymentError

Author: teo

core/task/errors.go

@@ -72,7 +72,7 @@ func (r GenericTasksError) Error() string {
 
 type TasksDeploymentError tasksErrorBase
 func (r TasksDeploymentError) Error() string {
-	return fmt.Sprintf("deployment failed for tasks [%s]", r.taskIds)
+	return fmt.Sprintf("deployment failed for tasks [%s]", strings.Join(r.taskIds, ", "))
 }
 
 type TaskAlreadyReleasedError taskErrorBase

core/task/manager.go

@@ -260,12 +260,12 @@ func (m *Manager) AcquireTasks(envId uuid.Array, taskDescriptors Descriptors) (e
 		// While all the required roles are running, for some reason we
 		// can't lock some of them, so we must roll back and keep them
 		// unlocked in the roster.
-		var deployedTaskNames []string
+		var deployedTaskIds []string
 		for taskPtr, _ := range deployedTasks {
 			taskPtr.parent = nil
-			deployedTaskNames = append(deployedTaskNames, taskPtr.name)
+			deployedTaskIds = append(deployedTaskIds, taskPtr.taskId)
 		}
-		err = TasksDeploymentError{taskIds: deployedTaskNames}
+		err = TasksDeploymentError{taskIds: deployedTaskIds}
 	}
 
 	// Finally, we write to the roster. Point of no return!