We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 94c6004 commit 2317e45Copy full SHA for 2317e45
1 file changed
executor/executable/controllabletask.go
@@ -728,8 +728,8 @@ func (t *ControllableTask) Kill() error {
728
}).
729
Debug("state DONE not reached, about to commit transition")
730
731
- // Call cmd.Commit() asynchronous
732
- commitDone := make(chan *CommitResponse)
+ // Call cmd.Commit() asynchronous with buffered channel so it doesn't get stuck in a case of timeout
+ commitDone := make(chan *CommitResponse, 1)
733
go func() {
734
var cr CommitResponse
735
cr.newState, cr.transitionError = cmd.Commit()
@@ -856,7 +856,6 @@ func (t *ControllableTask) doKill9(pid int) error {
856
}
857
858
func (t *ControllableTask) doTermIntKill(pid int) error {
859
-
860
killErrCh := make(chan error)
861
862
log.WithField("partition", t.knownEnvironmentId.String()).
0 commit comments