document that we don't need to close pipes if command fails to start

knopers8 · knopers8 · commit 5d2bb0b3500a · 2025-12-15T11:38:58.000+01:00
diff --git a/executor/executable/controllabletask.go b/executor/executable/controllabletask.go
@@ -147,7 +147,7 @@ func (t *ControllableTask) doLaunchTask(taskCmd *exec.Cmd, launchStartTime time.
 			Error("failed to run task")
 
 		t.sendStatus(t.knownEnvironmentId, mesos.TASK_FAILED, err.Error())
-		// fixme: shouldn't we also close pipes, as we do in some other error cases later?
+		// no need to close IO pipes, Cmd.Start does it on failure
 		return
 	}
 	log.WithFields(defaultLogFields).Debug("task launched")

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ func (t ControllableTask) doLaunchTask(taskCmd exec.Cmd, launchStartTime time.`
`147`	`147`	`Error("failed to run task")`
`148`	`148`
`149`	`149`	`t.sendStatus(t.knownEnvironmentId, mesos.TASK_FAILED, err.Error())`
`150`		`- // fixme: shouldn't we also close pipes, as we do in some other error cases later?`
	`150`	`+ // no need to close IO pipes, Cmd.Start does it on failure`
`151`	`151`	`return`
`152`	`152`	`}`
`153`	`153`	`log.WithFields(defaultLogFields).Debug("task launched")`