[QC-912] Fix storing user metadata in Checks (#1604)

Author: knopers8

Framework/src/QualityObject.cxx

@@ -37,7 +37,7 @@ QualityObject::QualityObject(
     mMonitorObjectsNames{ std::move(monitorObjectsNames) },
     mActivity(runNumber, 0, "", "", "qc")
 {
-  mQuality.overwriteMetadata(std::move(metadata));
+  mQuality.addMetadata(std::move(metadata));
 }
 
 QualityObject::~QualityObject() = default;

Framework/test/testQualityObject.cxx

@@ -65,6 +65,12 @@ BOOST_AUTO_TEST_CASE(quality_object_test_constructors)
   BOOST_CHECK_EQUAL(qo2.getMetadataMap().at("probability"), "0.45");
   BOOST_REQUIRE_EQUAL(qo2.getMetadataMap().count("threshold_medium"), 1);
   BOOST_CHECK_EQUAL(qo2.getMetadataMap().at("threshold_medium"), "0.42");
+
+  Quality q(123, "defCheck");
+  q.addMetadata("mykey", "myvalue");
+  QualityObject qo3{ q, "defCheck" };
+  BOOST_REQUIRE_EQUAL(qo3.getMetadataMap().count("mykey"), 1);
+  BOOST_CHECK_EQUAL(qo3.getMetadataMap().at("mykey"), "myvalue");
 }
 
 BOOST_AUTO_TEST_CASE(quality_object_test_setters)

Modules/Skeleton/src/SkeletonCheck.cxx

@@ -57,6 +57,7 @@ Quality SkeletonCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
                            "This is to demonstrate that we can assign more than one Reason to a Quality");
         }
       }
+      result.addMetadata("mykey", "myvalue");
     }
   }
   return result;