esthetic changes in QC

Author: Barthelemy

example-default.ini

@@ -13,12 +13,14 @@ taskDefinition=taskDefinition_1
 taskDefinition=taskDefinition_1
 
 [taskDefinition_1]
-className=AliceO2::QualityControlModules::Example::ExampleTask
+className=AliceO2::QualityControlModules::Template::TemplateTask
+;className=AliceO2::QualityControlModules::Example::ExampleTask
 moduleName=QcExample
 cycleDurationSeconds=10
 numberHistos=1000
 numberChecks=10
-typeOfChecks=AliceO2::QualityControlModules::Example::FakeCheck
+;typeOfChecks=AliceO2::QualityControlModules::Example::FakeCheck
+typeOfChecks=AliceO2::QualityControlModules::Template::TemplateCheck
 ; set to -1 for no maximum or remove the line
 maxNumberCycles=-1
 ;exampleTaskOutput=0

include/QualityControl/SpyDevice.h

@@ -37,8 +37,7 @@ class SpyDevice: public FairMQDevice
 
     ~SpyDevice() override;
 
-    static void CustomCleanup(void *data, void* hint);
-    void stop();
+    void stopSpy();
     void displayObject(std::string objectName);
 
     void setFrame(SpyMainFrame *frame);

src/Checker.cxx

@@ -5,24 +5,16 @@
 
 #include "QualityControl/Checker.h"
 
-// std
-#include <iostream>
-#include <chrono>
-#include <algorithm>
 // ROOT
 #include <TMessage.h>
 #include <TSystem.h>
 #include <TClass.h>
 // FairRoot
-#include <FairMQPoller.h>
-#include <Configuration/ConfigurationInterface.h>
 #include <Configuration/ConfigurationFactory.h>
 // O2
 #include "Common/Exceptions.h"
 // QC
-#include "QualityControl/CheckInterface.h"
 #include "QualityControl/DatabaseFactory.h"
-#include "QualityControl/CheckerConfig.h"
 
 using namespace AliceO2::Common;
 using namespace AliceO2::Configuration;

src/SpyDevice.cxx

@@ -34,9 +34,9 @@ void SpyDevice::setFrame(SpyMainFrame *frame)
   mFrame = frame;
 }
 
-void SpyDevice::stop()
+void SpyDevice::stopSpy()
 {
-  // TODO if current state is running {
+  // TODO if current state is running {   CheckCurrentState(RUNNING)?
   ChangeState("STOP"); // synchronous
   ChangeState("RESET_TASK");
   WaitForEndOfState("RESET_TASK");

src/SpyMainFrame.cxx

@@ -155,7 +155,7 @@ void SpyMainFrame::constructWindow()
 void SpyMainFrame::closeWindow()
 {
   // Got close message for this MainFrame. Terminates the application.
-  mController->stop();
+  mController->stopSpy();
   gApplication->Terminate();
 }
 
@@ -266,7 +266,7 @@ void SpyMainFrame::stop()
     mDbRunning = false;
   } else {
     // toggle buttons and remove list
-    if(!mSourceFairmq->IsEnabled()) {
+    if (!mSourceFairmq->IsEnabled()) {
       mSourceFairmq->SetEnabled(true);
       mSourceDb->SetEnabled(true);
       mSourceLabel->Disable(false);
@@ -300,9 +300,9 @@ void SpyMainFrame::dbRun()
 void SpyMainFrame::dbDisplayObject(string objectName)
 {
   string taskName = objectName.substr(0, objectName.find("/"));
-  string objectNameOnly = objectName.substr(objectName.find("/")+1);
-  AliceO2::QualityControl::Core::MonitorObject* mo = mDbInterface->retrieve(taskName, objectNameOnly);
-  if(mo) {
+  string objectNameOnly = objectName.substr(objectName.find("/") + 1);
+  AliceO2::QualityControl::Core::MonitorObject *mo = mDbInterface->retrieve(taskName, objectNameOnly);
+  if (mo) {
     displayObject(mo->getObject());
     delete mo;
   } else {

src/TaskDevice.cxx

@@ -10,7 +10,6 @@
 #include <QualityControl/QcInfoLogger.h>
 #include <QualityControl/TaskFactory.h>
 #include <TMessage.h>
-#include "Monitoring/Collector.h"
 #include <TClass.h>
 #include "DataSampling/SamplerFactory.h"