Code improvements following clang-tidy

Author: Barthelemy

include/QualityControl/MonitorObject.h

@@ -38,6 +38,15 @@ class MonitorObject : public TObject
     /// Destructor
     ~MonitorObject() override;
 
+    /// Copy constructor
+    MonitorObject (const MonitorObject& other) = default;
+    /// Move constructor
+    MonitorObject (MonitorObject&& other) noexcept = default;
+    /// Copy assignment operator
+    MonitorObject& operator= (const MonitorObject& other) = default;
+    /// Move assignment operator
+    MonitorObject& operator= (MonitorObject&& other) noexcept = default;
+
     const std::string &getName() const
     {
       return mName;

include/QualityControl/SpyDevice.h

@@ -34,8 +34,7 @@ class SpyDevice: public FairMQDevice
 {
   public:
     SpyDevice();
-
-    ~SpyDevice() override;
+    ~SpyDevice() override = default;
 
     void stopSpy();
     void displayObject(std::string objectName);

src/ObjectsManager.cxx

@@ -24,15 +24,15 @@ ObjectsManager::ObjectsManager(TaskConfig &taskConfig) : mTaskName(taskConfig.ta
 
 ObjectsManager::~ObjectsManager()
 {
-  for (auto obj = mMonitorObjects.begin(); obj != mMonitorObjects.end(); obj++) {
-    delete obj->second;
+  for (auto &mMonitorObject : mMonitorObjects) {
+    delete mMonitorObject.second;
   }
   mMonitorObjects.clear();
 }
 
 void ObjectsManager::startPublishing(TObject *object, std::string objectName)
 {
-  std::string nonEmptyName = objectName == "" ? object->GetName() : objectName;
+  std::string nonEmptyName = objectName.empty() ? object->GetName() : objectName;
   auto *newObject = new MonitorObject(nonEmptyName, object, mTaskName);
   newObject->setIsOwner(false);
   mMonitorObjects[nonEmptyName] = newObject;

src/SpyDevice.cxx

@@ -27,10 +27,6 @@ SpyDevice::SpyDevice()
   SetTransport("zeromq"); // or "nanomsg", etc
 }
 
-SpyDevice::~SpyDevice()
-{
-}
-
 void SpyDevice::setFrame(SpyMainFrame *frame)
 {
   mFrame = frame;
@@ -56,13 +52,13 @@ void SpyDevice::Run()
     while (fChannels.at("data-in").at(0).ReceiveAsync(message) > 0) {
       TestTMessage tm(message->GetData(), message->GetSize());
       TObject *tobj = tm.ReadObject(tm.GetClass());
-      if (tobj) {
+      if (tobj != nullptr) {
         // TODO once the bug in ROOt that removes spaces in strings passed in signal slot is fixed we can use the normal name.
         string objectName = tobj->GetName();
-        MonitorObject *mo = dynamic_cast<MonitorObject*>(tobj);
+        auto *mo = dynamic_cast<MonitorObject*>(tobj);
         Quality q = mo ? mo->getQuality() : Quality::Null;
         boost::erase_all(objectName, " ");
-        if (mCache.count(objectName) && mCache[objectName]) {
+        if (mCache.count(objectName) > 0 && mCache[objectName] != nullptr) {
           delete mCache[objectName];
         }
         mCache[objectName] = tobj;

src/SpyMainFrame.cxx

@@ -204,7 +204,7 @@ void SpyMainFrame::displayObject(TObject *obj)
     gPad->Clear();
   }
 
-  string drawOptions = "";
+  string drawOptions;
   if (((AliceO2::QualityControl::Core::MonitorObject *) obj)->getObject()->IsA() == TGraph::Class()) {
     drawOptions = "ALP";
   }
@@ -240,7 +240,7 @@ void SpyMainFrame::updateList(string name, /*AliceO2::QualityControl::Core::Qual
     this->MapSubwindows();
     this->Resize();
     gSystem->ProcessEvents();
-  } else if (mDrawnObject) { // object is known and it is the one displayed -> redraw it
+  } else if (mDrawnObject != nullptr) { // object is known and it is the one displayed -> redraw it
     string noSpaceName = mDrawnObject->GetName();
     boost::erase_all(noSpaceName, " ");
     if (noSpaceName == name) {
@@ -306,10 +306,10 @@ void SpyMainFrame::dbRun()
 
 void SpyMainFrame::dbDisplayObject(string objectName)
 {
-  string taskName = objectName.substr(0, objectName.find("/"));
-  string objectNameOnly = objectName.substr(objectName.find("/") + 1);
+  string taskName = objectName.substr(0, objectName.find('/'));
+  string objectNameOnly = objectName.substr(objectName.find('/') + 1);
   AliceO2::QualityControl::Core::MonitorObject *mo = mDbInterface->retrieve(taskName, objectNameOnly);
-  if (mo) {
+  if (mo != nullptr) {
     displayObject(mo->getObject());
     delete mo;
   } else {