refactor: dotify query parameters before sending them (#115)

Author: Highjhacker

client/connection.py

@@ -71,15 +71,3 @@ def get(self, path, params=None):
     def post(self, path, data=None, params=None):
         response = self.session.post(path, json=data, params=params)
         return self._handle_response(response)
-
-    def put(self, path, data=None, params=None):
-        response = self.session.put(path, json=data, params=params)
-        return self._handle_response(response)
-
-    def patch(self, path, data=None, params=None):
-        response = self.session.patch(path, json=data, params=params)
-        return self._handle_response(response)
-
-    def delete(self, path, params=None):
-        response = self.session.delete(path, params=params)
-        return self._handle_response(response)

client/resource.py

@@ -1,20 +1,16 @@
+from flatten_dict import flatten
 
 class Resource(object):
 
     def __init__(self, connection):
         self.connection = connection
 
     def request_get(self, path, params=None):
+        if params:
+            params = flatten(params, reducer='dot')
         return self.connection.get(path, params=params)
 
     def request_post(self, path, data=None, params=None):
+        if params:
+            params = flatten(params, reducer='dot')
         return self.connection.post(path, data=data, params=params)
-
-    def request_put(self, path, data=None, params=None):
-        return self.connection.put(path, data=data, params=params)
-
-    def request_patch(self, path, data=None, params=None):
-        return self.connection.patch(path, data=data, params=params)
-
-    def request_delete(self, path, params=None):
-        return self.connection.delete(path, params=params)

setup.py

@@ -6,6 +6,7 @@
 requires = [
     'requests>=2.19.1',
     'backoff>=1.6.0',
+    'flatten_dict>=0.3.0'
 ]
 
 tests_require = [

tests/test_connection.py

@@ -101,10 +101,7 @@ def test_handle_response_retuns_body_from_request():
 
 @pytest.mark.parametrize('method,func_name', [
     (responses.GET, 'get'),
-    (responses.POST, 'post'),
-    (responses.PUT, 'put'),
-    (responses.PATCH, 'patch'),
-    (responses.DELETE, 'delete'),
+    (responses.POST, 'post')
 ])
 def test_http_methods_call_correct_url_and_return_correct_response(method, func_name):
     responses.add(
@@ -123,10 +120,7 @@ def test_http_methods_call_correct_url_and_return_correct_response(method, func_
 
 @pytest.mark.parametrize('method,func_name', [
     (responses.GET, 'get'),
-    (responses.POST, 'post'),
-    (responses.PUT, 'put'),
-    (responses.PATCH, 'patch'),
-    (responses.DELETE, 'delete'),
+    (responses.POST, 'post')
 ])
 def test_http_methods_call_correct_url_with_params_and_return_correct_response(method, func_name):
     responses.add(

tests/test_resource.py

@@ -21,32 +21,3 @@ def test_request_post_calls_connection_post_with_correct_params(mocker):
 
     post_mock.assert_called_once_with('spongebob', data={'one': 'two'}, params={'foo': 'bar'})
 
-
-def test_request_put_calls_connection_put_with_correct_params(mocker):
-    put_mock = mocker.patch.object(Connection, 'put')
-    connection = Connection('http://127.0.0.1:4003')
-
-    resource = Resource(connection)
-    resource.request_put('spongebob', data={'one': 'two'}, params={'foo': 'bar'})
-
-    put_mock.assert_called_once_with('spongebob', data={'one': 'two'}, params={'foo': 'bar'})
-
-
-def test_request_patch_calls_connection_patch_with_correct_params(mocker):
-    patch_mock = mocker.patch.object(Connection, 'patch')
-    connection = Connection('http://127.0.0.1:4003')
-
-    resource = Resource(connection)
-    resource.request_patch('spongebob', data={'one': 'two'}, params={'foo': 'bar'})
-
-    patch_mock.assert_called_once_with('spongebob', data={'one': 'two'}, params={'foo': 'bar'})
-
-
-def test_request_delete_calls_connection_delete_with_correct_params(mocker):
-    delete_mock = mocker.patch.object(Connection, 'delete')
-    connection = Connection('http://127.0.0.1:4003')
-
-    resource = Resource(connection)
-    resource.request_delete('spongebob', params={'foo': 'bar'})
-
-    delete_mock.assert_called_once_with('spongebob', params={'foo': 'bar'})