Skip to content

Commit 64de7a7

Browse files
committed
ASoC: macaudio: s/void_warranty/please_blow_up_my_speakers/
We have no idea whether any of this voids warranties, but what it does do is blow up your speakers, so let's be explicit about what users are signing up for. Signed-off-by: Hector Martin <marcan@marcan.st>
1 parent 92c6de0 commit 64de7a7

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

sound/soc/apple/macaudio.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ struct macaudio_snd_data {
6767
struct snd_pcm_hw_constraint_list speaker_nchans_list;
6868
};
6969

70-
static bool void_warranty;
71-
module_param(void_warranty, bool, 0644);
72-
MODULE_PARM_DESC(void_warranty, "Do not bail if safety is not assured");
70+
static bool please_blow_up_my_speakers;
71+
module_param(please_blow_up_my_speakers, bool, 0644);
72+
MODULE_PARM_DESC(please_blow_up_my_speakers, "Allow unsafe or untested operating configurations");
7373

7474
SND_SOC_DAILINK_DEFS(primary,
7575
DAILINK_COMP_ARRAY(COMP_CPU("mca-pcm-0")), // CPU
@@ -703,7 +703,7 @@ static int macaudio_late_probe(struct snd_soc_card *card)
703703
#define CHECK(call, pattern, value) \
704704
{ \
705705
int ret = call(card, pattern, value); \
706-
if (ret < 1 && !void_warranty) { \
706+
if (ret < 1 && !please_blow_up_my_speakers) { \
707707
dev_err(card->dev, "%s on '%s': %d\n", #call, pattern, ret); \
708708
return ret; \
709709
} \
@@ -779,7 +779,7 @@ static int macaudio_fallback_fixup_controls(struct snd_soc_card *card)
779779
{
780780
struct macaudio_snd_data *ma = snd_soc_card_get_drvdata(card);
781781

782-
if (ma->has_speakers && !void_warranty) {
782+
if (ma->has_speakers && !please_blow_up_my_speakers) {
783783
dev_err(card->dev, "driver can't assure safety on this model, refusing probe\n");
784784
return -EINVAL;
785785
}

0 commit comments

Comments
 (0)