From 8313ee02b37c4279d65625b3613662c2f7d2319c Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Wed, 6 May 2026 17:14:58 +0000 Subject: [PATCH] Route new signups to trending Co-authored-by: Ray Jacobson --- packages/web/e2e/signUp.test.ts | 2 +- packages/web/src/pages/sign-on-page/SignOnPage.tsx | 12 +++++++++++- packages/web/src/pages/sign-up-page/SignUpPage.tsx | 4 ++-- .../pages/sign-up-page/pages/MobileAppCtaPage.tsx | 2 +- .../sign-up-page/utils/getSignUpCompletionRoute.ts | 9 +++++++++ .../sign-up-page/utils/useDetermineAllowedRoutes.ts | 4 ++-- 6 files changed, 26 insertions(+), 7 deletions(-) create mode 100644 packages/web/src/pages/sign-up-page/utils/getSignUpCompletionRoute.ts diff --git a/packages/web/e2e/signUp.test.ts b/packages/web/e2e/signUp.test.ts index bb94c53f5b5..5433c5cb2eb 100644 --- a/packages/web/e2e/signUp.test.ts +++ b/packages/web/e2e/signUp.test.ts @@ -181,7 +181,7 @@ async function testSignUp({ }) ).toBeVisible({ timeout: 60000 }) // This can take a long time await page.getByRole('button', { name: /start listening/i }).click() - await expect(page).toHaveURL(/feed/i) + await expect(page).toHaveURL(/trending/i) } test.describe('Sign Up', () => { diff --git a/packages/web/src/pages/sign-on-page/SignOnPage.tsx b/packages/web/src/pages/sign-on-page/SignOnPage.tsx index a1646fda6d3..d05a3bfb453 100644 --- a/packages/web/src/pages/sign-on-page/SignOnPage.tsx +++ b/packages/web/src/pages/sign-on-page/SignOnPage.tsx @@ -45,6 +45,7 @@ import { useMedia } from 'hooks/useMedia' import { SignInPage } from 'pages/sign-in-page' import SignUpPage from 'pages/sign-up-page' import { NavHeader } from 'pages/sign-up-page/components/NavHeader' +import { getSignUpCompletionRoute } from 'pages/sign-up-page/utils/getSignUpCompletionRoute' import landingImg from 'public-site/pages/landing-2026/assets/landing.png' const { @@ -317,9 +318,18 @@ export const SignOnPage = () => { const SignOnRoot = isMobile ? MobileSignOnRoot : DesktopSignOnRoot const location = useLocation() const isSignUp = location.pathname.startsWith(SIGN_UP_PAGE) + const signInCompletionRoute = completionRoute ? completionRoute : FEED_PAGE if (signOnStatus === EditingStatus.SUCCESS) { - return + return ( + + ) } return ( diff --git a/packages/web/src/pages/sign-up-page/SignUpPage.tsx b/packages/web/src/pages/sign-up-page/SignUpPage.tsx index 463457f6356..1c2c8f3fd15 100644 --- a/packages/web/src/pages/sign-up-page/SignUpPage.tsx +++ b/packages/web/src/pages/sign-up-page/SignUpPage.tsx @@ -6,6 +6,7 @@ import { useSelector } from 'react-redux' import { Navigate, Route, Routes, useLocation } from 'react-router' import { getRouteOnCompletion } from 'common/store/pages/signon/selectors' +import { getSignUpCompletionRoute } from 'pages/sign-up-page/utils/getSignUpCompletionRoute' import { useDetermineAllowedRoute } from 'pages/sign-up-page/utils/useDetermineAllowedRoutes' import { CreateEmailPage } from './pages/CreateEmailPage' @@ -20,7 +21,6 @@ import { SelectGenresPage } from './pages/SelectGenresPage' import { RouteContextProvider } from './utils/RouteContext' const { - FEED_PAGE, TRENDING_PAGE, SIGN_UP_APP_CTA_PAGE, SIGN_UP_ARTISTS_PAGE, @@ -161,7 +161,7 @@ export const SignUpPage = () => { path='completed' element={ - + } /> diff --git a/packages/web/src/pages/sign-up-page/pages/MobileAppCtaPage.tsx b/packages/web/src/pages/sign-up-page/pages/MobileAppCtaPage.tsx index 0f06f085496..2364d856bed 100644 --- a/packages/web/src/pages/sign-up-page/pages/MobileAppCtaPage.tsx +++ b/packages/web/src/pages/sign-up-page/pages/MobileAppCtaPage.tsx @@ -40,7 +40,7 @@ export const MobileAppCtaPage = () => { const status = useSelector(getStatus) const handleContinue = useCallback(() => { - // If account creation is complete, go to feed + // If account creation is complete, go to the post-signup landing page // Otherwise, show loading screen until account is ready if (status === EditingStatus.SUCCESS) { navigate(SIGN_UP_COMPLETED_REDIRECT) diff --git a/packages/web/src/pages/sign-up-page/utils/getSignUpCompletionRoute.ts b/packages/web/src/pages/sign-up-page/utils/getSignUpCompletionRoute.ts new file mode 100644 index 00000000000..4dc865764c2 --- /dev/null +++ b/packages/web/src/pages/sign-up-page/utils/getSignUpCompletionRoute.ts @@ -0,0 +1,9 @@ +import { FEED_PAGE, TRENDING_PAGE } from '@audius/common/src/utils/route' + +export const getSignUpCompletionRoute = (completionRoute: string) => { + if (completionRoute === FEED_PAGE) { + return TRENDING_PAGE + } + + return completionRoute ? completionRoute : TRENDING_PAGE +} diff --git a/packages/web/src/pages/sign-up-page/utils/useDetermineAllowedRoutes.ts b/packages/web/src/pages/sign-up-page/utils/useDetermineAllowedRoutes.ts index 2c48e93f452..fa728ea6393 100644 --- a/packages/web/src/pages/sign-up-page/utils/useDetermineAllowedRoutes.ts +++ b/packages/web/src/pages/sign-up-page/utils/useDetermineAllowedRoutes.ts @@ -12,7 +12,7 @@ import { env } from 'services/env' import { useFastReferral } from '../hooks/useFastReferral' -const { FEED_PAGE, SignUpPath } = route +const { TRENDING_PAGE, SignUpPath } = route const isDevEnvironment = env.ENVIRONMENT === 'development' || @@ -63,7 +63,7 @@ export const useDetermineAllowedRoute = () => { return { allowedRoutes: [], isAllowedRoute: false, - correctedRoute: FEED_PAGE + correctedRoute: TRENDING_PAGE } } // Normalize path: strip /signup/ or signup/ prefix and trailing slash so "select-genres" always matches