Issue : #62

Reviewed by: Sunny and Ashutosh
Changes made : Adding Timeout for http connection and http read data.
Adding the constants for same which read value from properties file.

Author: akankari

anet-java-sdk.properties

@@ -23,4 +23,8 @@ md5.hash.key=MD5_HASH_KEY
 # http.ProxyUse=true
 # https.proxyHost=HTTPS_PROXY_HOST
 # https.proxyPort=HTTPS_PROXY_PORT
-# https.proxyUse=true
+# https.proxyUse=true
+
+#Settings for HTTP connection timeouts (in milliseconds)
+HTTP_CONNECTION_TIME_OUT=30000
+HTTP_READ_TIME_OUT=30000

src/main/java/net/authorize/util/Constants.java

@@ -25,5 +25,8 @@ public final class Constants {
 
 	public static final String PROP_API_LOGINID_APPLEPAY = "api.login.id.applepay";
 	public static final String PROP_TRANSACTION_KEY_APPLEPAY = "transaction.key.applepay";
-	public static final String PROP_MD5_HASHKEY_APPLEPAY = "md5.hash.key.applepay";	
+	public static final String PROP_MD5_HASHKEY_APPLEPAY = "md5.hash.key.applepay";
+	
+	public static final String HTTP_CONNECTION_TIME_OUT = "HTTP_CONNECTION_TIME_OUT";
+	public static final String HTTP_READ_TIME_OUT = "HTTP_READ_TIME_OUT";
 }

src/main/java/net/authorize/util/HttpClient.java

@@ -24,9 +24,13 @@
 import org.apache.http.conn.params.ConnRoutePNames;
 import org.apache.http.entity.StringEntity;
 import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.params.BasicHttpParams;
 import org.apache.http.params.CoreProtocolPNames;
+import org.apache.http.params.HttpConnectionParams;
+import org.apache.http.params.HttpParams;
 import org.apache.http.protocol.HTTP;
 
+
 /**
  * Transportation object used to facilitate the communication with the respective gateway.
  *
@@ -40,7 +44,9 @@ public class HttpClient {
 	static boolean UseProxy = Environment.getBooleanProperty(Constants.HTTPS_USE_PROXY);
 	static String ProxyHost = Environment.getProperty(Constants.HTTPS_PROXY_HOST);
 	static int ProxyPort = Environment.getIntProperty(Constants.HTTPS_PROXY_PORT);
-	
+	static int httpConnectionTimeout = Environment.getIntProperty(Constants.HTTP_CONNECTION_TIME_OUT);
+	static int httpReadTimeout = Environment.getIntProperty(Constants.HTTP_READ_TIME_OUT);
+			
 	static {
 		LogHelper.info(logger, "Use Proxy: '%s'", UseProxy);
 	}
@@ -71,17 +77,28 @@ private static HttpPost createHttpPost(Environment env, Transaction transaction)
   		    httpPost = new HttpPost(postUrl);
 
             httpPost.getParams().setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE, false);
+            
+			//set the tcp connection timeout
+			httpPost.getParams().setIntParameter(HttpConnectionParams.CONNECTION_TIMEOUT, httpConnectionTimeout);
+			//set the time out on read-data request
+			httpPost.getParams().setIntParameter(HttpConnectionParams.SO_TIMEOUT, httpReadTimeout);
+            
 		    httpPost.setHeader("Content-Type", "application/x-www-form-urlencoded; charset=utf-8");
-
 		    httpPost.setEntity(new StringEntity(transaction.toNVPString()));
 		} else if (transaction instanceof net.authorize.arb.Transaction ||
 			    transaction instanceof net.authorize.cim.Transaction ||
 			    transaction instanceof net.authorize.reporting.Transaction) {
 
 			  postUrl = new URI(env.getXmlBaseUrl() + "/xml/v1/request.api");
 			  httpPost = new HttpPost(postUrl);
-                          httpPost.getParams().setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE, false);
-			  httpPost.setHeader("Content-Type", "text/xml; charset=utf-8");
+              httpPost.getParams().setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE, false);
+
+              //set the TCP connection timeout
+              httpPost.getParams().setIntParameter(HttpConnectionParams.CONNECTION_TIMEOUT, httpConnectionTimeout);
+              //set the time out on read-data request
+              httpPost.getParams().setIntParameter(HttpConnectionParams.SO_TIMEOUT, httpReadTimeout);
+
+              httpPost.setHeader("Content-Type", "text/xml; charset=utf-8");
 			  httpPost.setEntity(new StringEntity(transaction.toXMLString()));
 		}