Commit e2ea160
[Created by Copilot on behalf of @bghgary]
Re-enable the "should trigger error callback with invalid server"
WebSocket test that was commented out in #130 due to the flake reported
in #131.
## Why this is safe to re-enable
Two WebSocket-related fixes landed on `main` since the flake was
observed:
- **#150** — pulled in UrlLib BabylonJS/UrlLib#26, which consolidates
`onError`/`onClose` dispatch on Windows and Apple. Before this, the
Windows and Apple implementations only fired `onError` on connection
failures without a matching `onClose`, leaving consumers (and this test)
in inconsistent terminal-event states.
- **#160** — made the JS-layer `close()` idempotent and `send()`
spec-compliant when CLOSING/CLOSED, fixing cross-state dispatch bugs.
## Verification
Repro PR #161 expanded this test to 20 sequential iterations on the same
branch to exercise the historical 1/3 flake rate. If the flake
persisted, P(all 20 pass) ≈ 0.03%. CI on #161 ran across every
platform/engine combo — Chakra/V8/JSI on UWP/Win32, Linux (gcc, clang,
sanitizers, TSan), macOS (Xcode 16.4, sanitizers, TSan), iOS (Xcode
15.2, 16.4) — and **all 20 iterations passed on every job** ([workflow
run
24587856930](https://github.com/BabylonJS/JsRuntimeHost/actions/runs/24587856930)).
This PR restores the original single test (no loop, default mocha
timeout) as it was before #130.
Fixes #131.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 4e81f0a commit e2ea160
1 file changed
Lines changed: 19 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
526 | 526 | | |
527 | 527 | | |
528 | 528 | | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
536 | 548 | | |
537 | 549 | | |
538 | 550 | | |
| |||
0 commit comments