Added tests

Author: Bernardo-MG

src/app/authentication/service/authentication.service.ts

@@ -14,7 +14,7 @@ export class AuthenticationService {
 
   private loginUrl = environment.apiUrl + "/login";
 
-  public user: User = new User();
+  private user: User = new User();
 
   constructor(
     private http: HttpClient

src/app/login/components/login-form/login-form.component.html

@@ -19,7 +19,7 @@ <h4 class="card-header">Login</h4>
                         Password is required
                     </div>
                 </div>
-                <button [disabled]="!canLogin()" class="btn btn-primary">
+                <button [disabled]="!canLogin()" class="btn btn-primary" [attr.aria-disabled]="!canLogin()" aria-label="Login">
                     <span *ngIf="loading" class="spinner-border spinner-border-sm mr-1"></span>
                     Login
                 </button>

src/app/login/components/login-form/login-form.component.spec.ts

@@ -31,4 +31,19 @@ describe('LoginFormComponent', () => {
   it('should create', () => {
     expect(component).toBeTruthy();
   });
+
+  it('should disable the login button by default', () => {
+    const button = fixture.nativeElement.querySelector('form button');
+    expect(button.disabled).toEqual(true);
+  });
+
+  it('should enable the login button when the form is valid', () => {
+    component.form.controls['username'].setValue('username');
+    component.form.controls['password'].setValue('password');
+    fixture.detectChanges();
+
+    const button = fixture.nativeElement.querySelector('form button');
+    expect(button.disabled).toEqual(false);
+  });
+
 });

src/app/login/containers/logout-button/logout-button.component.spec.ts

@@ -1,23 +1,36 @@
 import { HttpClientTestingModule } from '@angular/common/http/testing';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
+import { User } from '@app/authentication/model/user';
+import { AuthenticationService } from '@app/authentication/service/authentication.service';
 import { LogoutButtonComponent } from './logout-button.component';
 
 describe('LogoutButtonComponent', () => {
   let component: LogoutButtonComponent;
   let fixture: ComponentFixture<LogoutButtonComponent>;
+  let authenticationServiceStub: Partial<AuthenticationService>;
+  let user: User;
 
   beforeEach(async () => {
+    user = new User();
+
+    authenticationServiceStub = {
+      getUser(): User {
+        return user;
+      }
+    };
+
     await TestBed.configureTestingModule({
       imports: [
         HttpClientTestingModule,
         RouterTestingModule
       ],
-      declarations: [ 
+      declarations: [
         LogoutButtonComponent
-       ]
+      ],
+      providers: [{ provide: AuthenticationService, useValue: authenticationServiceStub }]
     })
-    .compileComponents();
+      .compileComponents();
   });
 
   beforeEach(() => {
@@ -29,4 +42,18 @@ describe('LogoutButtonComponent', () => {
   it('should create', () => {
     expect(component).toBeTruthy();
   });
+
+  it('should be disabled by default', () => {
+    const button = fixture.nativeElement.querySelector('button');
+    expect(button.disabled).toEqual(true);
+  });
+
+  it('if the user is logged the button is enabled', () => {
+    user.logged = true;
+    fixture.detectChanges();
+
+    const button = fixture.nativeElement.querySelector('button');
+    expect(button.disabled).toEqual(false);
+  });
+
 });

src/app/login/view/login-view/login-view.component.spec.ts

@@ -1,4 +1,6 @@
+import { HttpClientTestingModule } from '@angular/common/http/testing';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { RouterTestingModule } from '@angular/router/testing';
 
 import { LoginViewComponent } from './login-view.component';
 
@@ -8,9 +10,15 @@ describe('LoginViewComponent', () => {
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      declarations: [ LoginViewComponent ]
+      imports: [
+        HttpClientTestingModule,
+        RouterTestingModule
+      ],
+      declarations: [
+        LoginViewComponent
+      ]
     })
-    .compileComponents();
+      .compileComponents();
   });
 
   beforeEach(() => {
@@ -22,4 +30,5 @@ describe('LoginViewComponent', () => {
   it('should create', () => {
     expect(component).toBeTruthy();
   });
+
 });