ProofOfWork: rename check -> checkPow because we no longer want to throw when a hash is valid but over the target

Author: Thomas Kerin

src/Chain/ProofOfWork.php

@@ -38,7 +38,7 @@ public function __construct(Math $math, ParamsInterface $params)
      * @param int $bits
      * @return \GMP
      */
-    public function getTarget($bits): \GMP
+    public function getTarget(int $bits): \GMP
     {
         $negative = false;
         $overflow = false;
@@ -85,7 +85,7 @@ public function getDifficulty(int $bits): string
      * @param int $nBits
      * @return bool
      */
-    public function check(BufferInterface $hash, int $nBits): bool
+    public function checkPow(BufferInterface $hash, int $nBits): bool
     {
         $negative = false;
         $overflow = false;
@@ -96,7 +96,7 @@ public function check(BufferInterface $hash, int $nBits): bool
         }
 
         if ($this->math->cmp($hash->getGmp(), $target) > 0) {
-            throw new \RuntimeException("Hash doesn't match nBits");
+            return false;
         }
 
         return true;
@@ -109,7 +109,7 @@ public function check(BufferInterface $hash, int $nBits): bool
      */
     public function checkHeader(BlockHeaderInterface $header): bool
     {
-        return $this->check($header->getHash(), $header->getBits());
+        return $this->checkPow($header->getHash(), $header->getBits());
     }
 
     /**

tests/Chain/ProofOfWorkTest.php

@@ -42,20 +42,16 @@ public function testWhereBitsBelowMinimum()
         $params = new Params($math);
         $pow = new ProofOfWork(new Math(), $params);
         $bits = 1;
-        $pow->check(Buffer::hex('00000000a3bbe4fd1da16a29dbdaba01cc35d6fc74ee17f794cf3aab94f7aaa0'), $bits);
+        $pow->checkPow(Buffer::hex('00000000a3bbe4fd1da16a29dbdaba01cc35d6fc74ee17f794cf3aab94f7aaa0'), $bits);
     }
 
-    /**
-     * @expectedException \RuntimeException
-     * @expectedExceptionMessage Hash doesn't match nBits
-     */
     public function testWhereHashTooLow()
     {
         $math = new Math();
         $params = new Params($math);
         $pow = new ProofOfWork(new Math(), $params);
         $bits = 0x181287ba;
-        $pow->check(Buffer::hex('00000000a3bbe4fd1da16a29dbdaba01cc35d6fc74ee17f794cf3aab94f7aaa0'), $bits);
+        $this->assertFalse($pow->checkPow(Buffer::hex('00000000a3bbe4fd1da16a29dbdaba01cc35d6fc74ee17f794cf3aab94f7aaa0'), $bits));
     }
 
     /**