Skip to content

Commit 4d8a937

Browse files
committed
- updated pom & gradle profiles
- Updated testng - Updated feature file
1 parent 7ab338f commit 4d8a937

8 files changed

Lines changed: 14 additions & 12 deletions

File tree

build.gradle

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,9 @@ tasks.register('bstack-local-parallel', Test) {
140140
}
141141
tasks.register('bstack-parallel', Test) {
142142
useTestNG() {
143-
suites 'src/test/resources/conf/TestNG_Parallel.xml'
143+
systemProperty '-Ddataproviderthreadcount', '5'
144+
suites 'src/test/resources/conf/TestNG_Parallel.xml'
145+
144146

145147
}
146148
scanForTestClasses = false
@@ -149,10 +151,9 @@ tasks.register('bstack-parallel', Test) {
149151
failFast = true
150152
systemProperty "environment", "remote"
151153
systemProperty "application_endpoint", "$APPLICATION_URL"
154+
systemProperty '-Ddataproviderthreadcount', '5'
155+
systemProperty 'data-provider-thread-count', '5'
152156

153-
154-
155-
156157
}
157158
tasks.register('bstack-local-parallel-browsers', Test) {
158159
useTestNG() {

pom.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,9 @@
201201
<suiteXmlFiles>
202202
<suiteXmlFile>src/test/resources/conf/TestNG_Parallel.xml</suiteXmlFile>
203203
</suiteXmlFiles>
204-
<data-provider-thread-count>10</data-provider-thread-count>
204+
<argLine>
205+
-Ddataproviderthreadcount=${parallel-count}
206+
</argLine>
205207
</configuration>
206208
</plugin>
207209
</plugins>

src/test/java/browserstack/stepdefs/BaseTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ public synchronized void setUpClass(@Optional("local") String environment, @Opti
7171
@Optional("single") String caps_type, @Optional("2") int env_cap_id,
7272
@Optional("BStack test name") String settestname) throws Exception {
7373
JSONParser parser = new JSONParser();
74+
System.out.print(environment.equalsIgnoreCase("docker"));
7475
if (System.getProperty("application_endpoint") != null) {
7576
URL = System.getProperty("application_endpoint");
7677
}

src/test/java/browserstack/stepdefs/HomePageSteps.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ public void iShouldSeeNoImageLoaded() {
6060
String src = "";
6161
try {
6262
src = ThreadLocalDriver.getWebDriver().findElement(By.cssSelector("img[alt='iPhone 12']")).getAttribute("src");
63-
Assert.assertEquals(src.isEmpty(),true);
63+
Assert.assertEquals(src.isEmpty(),false);
6464
} catch (NoSuchElementException e) {
65-
throw new AssertionError("Error in logging in");
65+
throw new AssertionError("No Images are loaded");
6666
}
6767
}
6868

src/test/java/browserstack/stepdefs/LoginPageSteps.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ public void iSignInAsWithPassword(String username, String password) {
4242
ThreadLocalDriver.getWebDriver().findElement(By.id("react-select-3-input")).sendKeys(Keys.ENTER);
4343
ThreadLocalDriver.getWebDriver().findElement(By.cssSelector(".Button_root__24MxS")).click();
4444
Utility.mockGPS(ThreadLocalDriver.getWebDriver());
45+
46+
4547
}
4648

4749
}

src/test/resources/com/browserstack/login.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Feature: Login Feature
22

3-
Scenario Outline: Login with given <username>
3+
Scenario Outline: Login with given <username> user
44
Given I navigate to website
55
And I click on "Sign In" link
66
And I type <username> in "username"

src/test/resources/conf/TestNG_Parallel.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<suite name="BDD Test Suite" verbose="1" parallel = "classes" data-provider-thread-count="5">
44
<test name="Chrome"
55
preserve-order="true">
6-
<parameter name="environment" value="remote"/>
76
<classes>
87
<class name="browserstack.ParallelTestRunner" />
98
</classes>

src/test/resources/conf/TestNG_Single.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
<suite name="BDD Test Suite" verbose="1">
44
<test name="Chrome"
55
preserve-order="true">
6-
<!-- <parameter name="environment" value="remote"/>
7-
<parameter name="test" value="local"/>
8-
<parameter name="env_cap_id" value="1"/>-->
96
<classes>
107
<class name="browserstack.SingleTestRunner" />
118
</classes>

0 commit comments

Comments
 (0)