Skip to content

Commit 8707cfc

Browse files
authored
Merge pull request #5 from browserstack/minor-code-fixes
Removing the specific capabilities functionality
2 parents a3b9714 + 3964999 commit 8707cfc

6 files changed

Lines changed: 3 additions & 56 deletions

File tree

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99

1010
<properties>
11+
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1112
<maven.compiler.source>1.8</maven.compiler.source>
1213
<maven.compiler.target>1.8</maven.compiler.target>
1314
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>

src/test/java/com/browserstack/examples/core/ManagedWebDriver.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import org.openqa.selenium.WebDriver;
44

55
import com.browserstack.examples.core.config.Platform;
6-
import com.browserstack.examples.core.WebDriverFactory;
76

87
/**
98
* Created with IntelliJ IDEA.
@@ -31,10 +30,9 @@ public String getTestName() {
3130
}
3231

3332
public WebDriver getWebDriver() {
34-
String[] specificCapabilities = new String[0];
3533

3634
if (this.webDriver == null) {
37-
this.webDriver = this.webDriverFactory.createWebDriverForPlatform(platform, testName, specificCapabilities);
35+
this.webDriver = this.webDriverFactory.createWebDriverForPlatform(platform, testName);
3836
}
3937
return this.webDriver;
4038
}

src/test/java/com/browserstack/examples/core/WebDriverFactory.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import java.net.MalformedURLException;
55
import java.net.URL;
66
import java.nio.file.Paths;
7-
import java.util.Arrays;
87
import java.util.LinkedHashMap;
98
import java.util.List;
109
import java.util.Map;
@@ -103,17 +102,10 @@ private WebDriverConfiguration parseWebDriverConfig() {
103102
return webDriverConfiguration;
104103
}
105104

106-
public WebDriver createWebDriverForPlatform(Platform platform, String testName, String[] specificCapabilitiesKeys) {
105+
public WebDriver createWebDriverForPlatform(Platform platform, String testName) {
107106
WebDriver webDriver = null;
108107
try {
109108
Map<String, Object> specificCapabilitiesMap = new LinkedHashMap<>();
110-
if (webDriverConfiguration.getSpecificCapabilities() != null && specificCapabilitiesKeys.length > 0) {
111-
Arrays.stream(specificCapabilitiesKeys)
112-
.forEach(specificCapabilityKey -> webDriverConfiguration
113-
.getSpecificCapabilities()
114-
.getSpecificCapabilities(specificCapabilityKey)
115-
.forEach(caps -> caps.getCapabilityMap().forEach(specificCapabilitiesMap::put)));
116-
}
117109
switch (this.webDriverConfiguration.getDriverType()) {
118110
case onPremDriver:
119111
webDriver = createOnPremWebDriver(platform, specificCapabilitiesMap);

src/test/java/com/browserstack/examples/core/config/SpecificCapabilities.java

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/test/java/com/browserstack/examples/core/config/WebDriverConfiguration.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ public class WebDriverConfiguration {
2525
@JsonProperty("cloudDriver")
2626
private RemoteDriverConfig cloudDriverConfig;
2727

28-
@JsonProperty("specific_capabilities")
29-
private SpecificCapabilities specificCapabilities;
30-
3128
public List<Platform> getActivePlatforms() {
3229
List<Platform> activePlatforms = Collections.emptyList();
3330
switch (driverType) {
@@ -83,12 +80,4 @@ public RemoteDriverConfig getCloudDriverConfig() {
8380
public void setCloudDriverConfig(RemoteDriverConfig cloudDriverConfig) {
8481
this.cloudDriverConfig = cloudDriverConfig;
8582
}
86-
87-
public SpecificCapabilities getSpecificCapabilities() {
88-
return specificCapabilities;
89-
}
90-
91-
public void setSpecificCapabilities(SpecificCapabilities specificCapabilities) {
92-
this.specificCapabilities = specificCapabilities;
93-
}
9483
}

src/test/resources/capabilities.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,3 @@ cloudDriver:
5454
# os_version: '13.0'
5555
# device: iPhone XS
5656
# real_mobile: true
57-
58-
specific_capabilities:
59-
apply_auth_mask:
60-
- browserstack.maskBasicAuth: true
61-
apply_command_mask:
62-
- browserstack.maskCommands: setValues, getValues, setCookies, getCookies
63-
debug_test:
64-
- browserstack.debug: true
65-
browserstack.console: verbose
66-
browserstack.networkLogs: true
67-
browserstack.video: true
68-
browserstack.seleniumLogs: true

0 commit comments

Comments
 (0)