Review (#10)

Incorporated internal TU team validation review comments.
 
Co-authored-by: Roy de Kleijn <roy.k@browserstack.com>
Co-authored-by: s7arlord <rathilvasani@gmail.com>

Author: 3 people

README.md

@@ -170,7 +170,8 @@ Note: The ChromeDriver version must match the Chrome browser version on your mac
 
 - Install and start [Docker](https://docs.docker.com/get-docker/).
 - Note: Docker should be running on the test machine. Ensure Docker Compose is installed as well.
-- Run `docker-compose pull` from the current directory of the repository.
+
+- Run `docker-compose pull` from the `docker` directory of the repository.
 
 ## Running Your Tests
 
@@ -252,7 +253,7 @@ Note: The ChromeDriver version must match the Chrome browser version on your mac
 
 - Output
 
-  This run profile executes the entire test suite in parallel on a single browser, deployed on a docker image.
+  This run profile executes the entire test suite in parallel across multiple instances of the same browser, deployed on a docker image.
 
 - Note: By default, this execution would run maximum 5 test threads in parallel on Docker. Refer to the section ["Configuring the maximum parallel test threads for this repository"](#Configuring-the-maximum-parallel-test-threads-for-this-repository) for updating the parallel thread count based on your requirements.
 
@@ -475,7 +476,8 @@ In this section, we will run the test cases to test the internally hosted websit
 
   Maven:
   ```sh
-  mvn allure:generate
+
+  mvn allure:report
   ```
 
   Gradle:

docker/docker-compose.yml

@@ -1,43 +1,38 @@
 version: "3"
 services:
   chrome:
-    image: selenium/node-chrome:4.0.0
-    volumes:
-      - /dev/shm:/dev/shm
+    image: selenium/node-chrome:3.141.59-20210311
     depends_on:
       - selenium-hub
+    volumes:
+      - /dev/shm:/dev/shm
     environment:
-      - SE_EVENT_BUS_HOST=selenium-hub
-      - SE_EVENT_BUS_PUBLISH_PORT=4442
-      - SE_EVENT_BUS_SUBSCRIBE_PORT=4443
       - SCREEN_WIDTH=2880
       - SCREEN_HEIGHT=1800
+      - HUB_HOST=selenium-hub
+      - HUB_PORT=4444
+      - NODE_MAX_INSTANCES=5
+      - NODE_MAX_SESSION=5
     links:
       - selenium-hub:hub
-    scale: 4
-
   firefox:
-    image: selenium/node-firefox:4.0.0
-    volumes:
-      - /dev/shm:/dev/shm
+    image: selenium/node-firefox:3.141.59-20210311
     depends_on:
       - selenium-hub
+    volumes:
+      - /dev/shm:/dev/shm
     environment:
-      - SE_EVENT_BUS_HOST=selenium-hub
-      - SE_EVENT_BUS_PUBLISH_PORT=4442
-      - SE_EVENT_BUS_SUBSCRIBE_PORT=4443
       - SCREEN_WIDTH=2880
       - SCREEN_HEIGHT=1800
+      - HUB_HOST=selenium-hub
+      - NODE_MAX_INSTANCES=5
+      - NODE_MAX_SESSION=5
     links:
       - selenium-hub:hub
-    scale: 4
-
   selenium-hub:
-    image: selenium/hub:4.0.0
+    image: selenium/hub:3.141.59-20210311
     container_name: selenium-hub
     environment:
-      - GRID_MAX_SESSION=50
+      - GRID_MAX_SESSION=5
     ports:
-      - "4442:4442"
-      - "4443:4443"
       - "4444:4444"

src/test/java/com/browserstack/test/suites/TestBase.java

@@ -16,6 +16,7 @@
 import java.io.FileReader;
 import java.lang.reflect.Method;
 import java.net.URL;
+import java.util.Date;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.UUID;
@@ -36,10 +37,6 @@ public WebDriver getDriver() {
         return driver.get();
     }
 
-    public String getGeolocation() {
-        return "";
-    }
-
     @BeforeMethod
     @Parameters(value = {"environment", "testtype", "env_cap_id"})
     public void setUp(@Optional("on-prem") String environment, @Optional("single") String testtype, @Optional("0") int env_cap_id, Method m) throws Exception {
@@ -55,6 +52,7 @@ public void setUp(@Optional("on-prem") String environment, @Optional("single") S
 
             Map<String, String> commonCapabilities = (Map<String, String>) envs.get("common_caps");
             commonCapabilities.put("name", m.getName());
+            commonCapabilities.put("build", commonCapabilities.get("build") + " - " + new Date().getTime());
             Map<String, String> envCapabilities = (Map<String, String>) ((org.json.simple.JSONArray) envs.get("env_caps")).get(env_cap_id);
             Map<String, String> localCapabilities = (Map<String, String>) envs.get("local_binding_caps");
 

src/test/java/com/browserstack/test/suites/user/UserTest.java

@@ -44,7 +44,7 @@ public void loginAndCheckExistingOrders() {
     @Test
     public void addToFavourites() {
         getDriver().findElement(By.id("signin")).click();
-        getDriver().findElement(By.cssSelector("#username input")).sendKeys("existing_orders_user" + Keys.ENTER);
+        getDriver().findElement(By.cssSelector("#username input")).sendKeys("demouser" + Keys.ENTER);
         getDriver().findElement(By.cssSelector("#password input")).sendKeys("testingisfun99" + Keys.ENTER);
         getDriver().findElement(By.id("login-btn")).click();