control_socket: drop reset-ssrc

supposing that the only user was CoUniverse

+ introduced asprintf compat for Windows (asprintf is used)

Author: MartinPulec

src/audio/audio.cpp

@@ -931,25 +931,6 @@ static struct response *audio_sender_process_message(struct state_audio *s, stru
                 break;
         case SENDER_MSG_QUERY_VIDEO_MODE:
                 return new_response(RESPONSE_BAD_REQUEST, nullptr);
-        case SENDER_MSG_RESET_SSRC: {
-                assert(s->audio_tx_mode == MODE_SENDER);
-                const uint32_t old_ssrc = rtp_my_ssrc(s->audio_network_device);
-                auto          *old_devices = s->audio_network_device;
-                s->audio_network_device =
-                    initialize_audio_network(&s->audio_network_parameters);
-                if (s->audio_network_device == nullptr) {
-                        s->audio_network_device = old_devices;
-                        log_msg(LOG_LEVEL_ERROR,
-                                "[control] Audio: Unable to change SSRC!\n");
-                        return new_response(RESPONSE_INT_SERV_ERR, nullptr);
-                }
-
-                rtp_done(old_devices);
-                log_msg(LOG_LEVEL_NOTICE,
-                        "[control] Audio: changed SSRC from 0x%08" PRIx32 " to "
-                        "0x%08" PRIx32 ".\n",
-                        old_ssrc, rtp_my_ssrc(s->audio_network_device));
-        } break;
         }
         return new_response(RESPONSE_OK, nullptr);
 }

src/compat/strings.h

@@ -5,7 +5,7 @@
  * compatibility header for strcasecmp. strdup, strerror_s
  */
 /*
- * Copyright (c) 2024-2025 CESNET
+ * Copyright (c) 2024-2026 CESNET, zájmové sdružení právnických osob
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -72,14 +72,23 @@ COMPAT_MISC_EXT_C int __xpg_strerror_r(int errcode, char *buffer, size_t length)
 #endif // ! defined _WIN32
 
 // strdupa is defined as a macro
-#include <string.h>
 #ifndef strdupa
 #define strdupa(s) (char *) memcpy(alloca(strlen(s) + 1), s, strlen(s) + 1)
 #endif // defined strdupa
 
 COMPAT_MISC_EXT_C const char *ug_strcasestr(const char *haystack,
                                             const char *needle);
 
+#ifdef _WIN32
+COMPAT_MISC_EXT_C int asprintf(char **strp, const char *fmt, ...);
+#else
+        #ifdef __cplusplus
+                #include <cstdio>   // for asprintf
+        #else
+                #include <stdio.h>  // for asprintf
+        #endif
+#endif
+
 #undef COMPAT_MISC_EXT_C
 
 #endif // ! defined COMPAT_STRINGS_H_D54CAFC8_A1A0_4FF5_80A0_91F34FB11E12

src/control_socket.cpp

@@ -62,7 +62,7 @@
 #include "debug.h"
 #include "compat/net.h"            // for net related
 #include "compat/platform_pipe.h"
-#include "compat/strings.h"        // for strncasecmp, strcasecmp
+#include "compat/strings.h"        // for asprintf, strncasecmp, strcasecmp
 #include "compat/time.h"           // for timeval, gettimeofday
 #include "host.h"
 #include "messaging.h"
@@ -385,6 +385,28 @@ process_audio_message(struct module *root_module, const char *cmd)
         return new_response(RESPONSE_BAD_REQUEST, "unexpected audio msg");
 }
 
+static struct response *
+handle_removed_feature(char *message)
+{
+        char *space = strchr(message, ' ');
+        if (space != nullptr) {
+                *space = '\0';
+        }
+        char *msg = nullptr;
+        int rc = asprintf(
+            &msg, "%s has been removed. Let us know if you use this feature. ",
+            message);
+        if (rc != -1) {
+                bug_msg(LOG_LEVEL_ERROR, "%s", msg);
+        } else {
+                perror("");
+                msg = nullptr;
+        }
+        auto *resp = new_response(RESPONSE_BAD_REQUEST, msg);
+        free(msg);
+        return resp;
+}
+
 /**
   * @retval -1 exit thread
   * @retval -2 close handle
@@ -532,15 +554,13 @@ static int process_msg(struct control_state *s, fd_t client_fd, char *message, s
                         send_message(s->root_module, path_audio, (struct message *) msg_audio);
                 free_response(resp_audio);
         } else if(prefix_matches(message, "receiver ") || prefix_matches(message, "play") ||
-                        prefix_matches(message, "pause") || prefix_matches(message, "reset-ssrc")) {
+                        prefix_matches(message, "pause")) {
                 struct msg_sender *msg =
                         (struct msg_sender *)
                         new_message(sizeof(struct msg_sender));
                 if(prefix_matches(message, "receiver ")) {
                         strncpy(msg->receiver, suffix(message, "receiver "), sizeof(msg->receiver) - 1);
                         msg->type = SENDER_MSG_CHANGE_RECEIVER;
-                } else if(prefix_matches(message, "reset-ssrc")) {
-                        msg->type = SENDER_MSG_RESET_SSRC;
                 } else {
                         abort();
                 }
@@ -561,11 +581,9 @@ static int process_msg(struct control_state *s, fd_t client_fd, char *message, s
                 struct response *resp_audio =
                         send_message(s->root_module, path_audio, (struct message *) msg_audio);
                 free_response(resp_audio);
-        } else if (prefix_matches(message, "receiver-port ")) {
-                const char msg[] = "receiver-port has been removed. Let us "
-                                   "know if you use this feature. ";
-                bug_msg(LOG_LEVEL_ERROR, msg);
-                resp = new_response(RESPONSE_BAD_REQUEST, msg);
+        } else if (prefix_matches(message, "receiver-port ") ||
+                   prefix_matches(message, "reset-ssrc")) {
+                resp = handle_removed_feature(message);
         } else if(prefix_matches(message, "fec ")) {
                 auto *msg = reinterpret_cast<struct msg_universal *>(new_message(sizeof(struct msg_universal)));
                 char *fec = suffix(message, "fec ");
@@ -1050,8 +1068,7 @@ static void print_control_help() {
                         TBOLD("\tpause") "\n"
                         TBOLD("\tplay") "\n"
                         TBOLD("\treciever {pause|play}") "\n"
-                        TBOLD("\treset-ssrc") "\n"
-                        TBOLD("\t{receiver|sender}-port <XY>") "\n"
+                        TBOLD("\tsender-port <XY>") "\n"
                         TBOLD("\tfec {audio|video} <fec-string>") "\n"
                         TBOLD("\tcompress <new-compress>") "\n"
                         TBOLD("\tcompress param <new-compress-param>") "\n"

src/messaging.h

@@ -91,7 +91,6 @@ enum msg_sender_type {
         SENDER_MSG_MUTE_TOGGLE,
         SENDER_MSG_CHANGE_FEC,
         SENDER_MSG_QUERY_VIDEO_MODE,
-        SENDER_MSG_RESET_SSRC,
 };
 
 struct msg_sender {

src/utils/string.c

@@ -55,6 +55,7 @@
 typedef SSIZE_T ssize_t;
 #endif
 
+#include "compat/c23.h"
 #include "compat/strings.h"
 #include "utils/macros.h"    // for MIN
 #include "utils/string.h"
@@ -296,3 +297,23 @@ sprintf_append(char *str, const char *format, ...)
 
         return str;
 }
+
+#ifdef _WIN32
+int
+asprintf(char **strp, const char *fmt, ...)
+{
+        va_list ap;
+
+        va_start(ap, fmt);
+        // get number of required bytes
+        int size = vsnprintf(nullptr, 0, fmt, ap);
+        va_end(ap);
+
+        *strp = malloc(size + 1);
+        va_start(ap, fmt);
+        (void) vsnprintf(*strp, size + 1, fmt, ap);
+        va_end(ap);
+
+        return size;
+}
+#endif

src/video_rxtx/rtp.cpp

@@ -178,26 +178,6 @@ rtp_process_sender_message(struct rtp_rxtx_common *s, struct msg_sender *msg)
                 delete old_fec_state;
                 MSG(NOTICE, "Fec changed successfully\n");
         } break;
-        case SENDER_MSG_RESET_SSRC: {
-                ultragrid::pthread_mutex_guard lock(s->network_devices_lock);
-                const uint32_t    old_ssrc   = rtp_my_ssrc(s->network_device);
-                auto             *old_device = s->network_device;
-                s->network_device             = initialize_network(
-                    s->priv->requested_receiver, s->priv->rx_port,
-                    s->priv->tx_port, s->participants,
-                    s->priv->force_ip_version,
-                    s->priv->mcast_if, s->priv->ttl);
-                if (s->network_device == nullptr) {
-                        s->network_device = old_device;
-                        MSG(ERROR, "Unable to change SSRC!\n");
-                        return new_response(RESPONSE_INT_SERV_ERR, nullptr);
-                }
-                destroy_rtp_device(old_device);
-                MSG(NOTICE,
-                    "Changed SSRC from 0x%08" PRIx32 " to "
-                    "0x%08" PRIx32 ".\n",
-                    old_ssrc, rtp_my_ssrc(s->network_device));
-        } break;
         case SENDER_MSG_GET_STATUS:
         case SENDER_MSG_MUTE:
         case SENDER_MSG_UNMUTE: