Skip to content

Commit 21b5f77

Browse files
committed
Changed outlier severity metric to exclusive runtime as using inclusive runtime will, for example, give a large severity to an anomaly in a small wrapper function around a long running child function
Disabled recoverable errors being logged when HBOS/COPOD come across a function with no unlabeled events in the data set; this can happen for legitimate reasons
1 parent 0b03c48 commit 21b5f77

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

include/chimbuko/ad/ExecData.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ class ExecData_t {
489489
/**
490490
* @brief Return the outlier severity, representing how important the outlier is
491491
*/
492-
double get_outlier_severity() const{ return (double)get_runtime(); }
492+
double get_outlier_severity() const{ return (double)get_exclusive(); }
493493

494494
/**
495495
* @brief Set the label

src/ad/ADOutlier.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ Anomalies ADOutlierHBOS::run(int step) {
283283
}
284284
}
285285
else {
286-
recoverable_error(std::string("AD: Zero function runtimes "));
286+
//recoverable_error(std::string("AD: Zero function runtimes "));
287287
continue;
288288
}
289289
}
@@ -568,7 +568,7 @@ Anomalies ADOutlierCOPOD::run(int step) {
568568
}
569569
}
570570
else {
571-
recoverable_error(std::string("AD: Zero function runtimes "));
571+
///recoverable_error(std::string("AD: Zero function runtimes "));
572572
continue;
573573
}
574574
verboseStream << "Size of runtimes: " << runtimes.size() << ", func_id: " << func_id << std::endl;

0 commit comments

Comments
 (0)