Replaced std::cout with verboseStream in several places in ADOutlier to reduce spam

Fixed HBOSOutlierTestBPFile and SSTDOutlierTestBPFile not using the correct paths for the bpfiles; the path is now passed in as a cmdline variable
Added missing unit tests to run_all script

Author: giltirn

src/ad/ADOutlier.cpp

@@ -170,12 +170,12 @@ double ADOutlierSSTD::computeScore(CallListIterator_t ev, const SstdParam &stats
 unsigned long ADOutlierSSTD::compute_outliers(Anomalies &outliers,
 					      const unsigned long func_id,
 					      std::vector<CallListIterator_t>& data){
-  std::cout << "Finding outliers in events for func " << func_id << std::endl;
+  verboseStream << "Finding outliers in events for func " << func_id << std::endl;
 
 
   SstdParam& param = *(SstdParam*)m_param;
   if (param[func_id].count() < 2){
-    std::cout << "Less than 2 events in stats associated with that func, stats not complete" << std::endl;
+    verboseStream << "Less than 2 events in stats associated with that func, stats not complete" << std::endl;
     return 0;
   }
   unsigned long n_outliers = 0;
@@ -194,15 +194,15 @@ unsigned long ADOutlierSSTD::compute_outliers(Anomalies &outliers,
       itt->set_outlier_score(computeScore(itt, param));
 
       if (label == -1) {
-	std::cout << "!!!!!!!Detected outlier on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid()
+	verboseStream << "!!!!!!!Detected outlier on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid()
 		      << " runtime " << runtime << " mean " << mean << " std " << std << std::endl;
 	n_outliers += 1;
   	std::vector<double> sstd_stats{thr_hi, thr_lo, mean, std};
 	outliers.insert(itt, Anomalies::EventType::Outlier, sstd_stats); //insert into data structure containing captured anomalies
       }else{
 	//Capture maximum of one normal execution per io step
 	if(outliers.nFuncEvents(func_id, Anomalies::EventType::Normal) == 0){
-	  std::cout << "Detected normal event on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid()
+	  verboseStream << "Detected normal event on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid()
 			<< " runtime " << runtime << " mean " << mean << " std " << std << std::endl;
 
 	  outliers.insert(itt, Anomalies::EventType::Normal);
@@ -302,7 +302,7 @@ unsigned long ADOutlierHBOS::compute_outliers(Anomalies &outliers,
 					      const unsigned long func_id,
 					      std::vector<CallListIterator_t>& data){
 
-  std::cout << "Finding outliers in events for func " << func_id << std::endl;
+  verboseStream << "Finding outliers in events for func " << func_id << std::endl;
 
   HbosParam& param = *(HbosParam*)m_param;
 
@@ -448,7 +448,7 @@ unsigned long ADOutlierHBOS::compute_outliers(Anomalies &outliers,
       if (ad_score >= l_threshold) {
 
           itt->set_label(-1);
-          std::cout << "!!!!!!!Detected outlier on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
+          verboseStream << "!!!!!!!Detected outlier on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
           outliers.insert(itt, Anomalies::EventType::Outlier, runtime_i, ad_score, l_threshold); //insert into data structure containing captured anomalies
           n_outliers += 1;
 
@@ -458,9 +458,8 @@ unsigned long ADOutlierHBOS::compute_outliers(Anomalies &outliers,
         //Capture maximum of one normal execution per io step
         itt->set_label(1);
         if(outliers.nFuncEvents(func_id, Anomalies::EventType::Normal) == 0) {
-      	   std::cout << "Detected normal event on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
-      	   outliers.insert(itt, Anomalies::EventType::Normal);
-
+	  verboseStream << "Detected normal event on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
+	  outliers.insert(itt, Anomalies::EventType::Normal);
         }
 
       }
@@ -579,7 +578,7 @@ unsigned long ADOutlierCOPOD::compute_outliers(Anomalies &outliers,
 					      const unsigned long func_id,
 					      std::vector<CallListIterator_t>& data){
 
-  std::cout << "Finding outliers in events for func " << func_id << std::endl;
+  verboseStream << "Finding outliers in events for func " << func_id << std::endl;
 
   CopodParam& param = *(CopodParam*)m_param;
 
@@ -678,7 +677,7 @@ unsigned long ADOutlierCOPOD::compute_outliers(Anomalies &outliers,
       if (ad_score >= l_threshold) {
 
           itt->set_label(-1);
-          std::cout << "!!!!!!!Detected outlier on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
+          verboseStream << "!!!!!!!Detected outlier on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
           outliers.insert(itt, Anomalies::EventType::Outlier, runtime_i, ad_score, l_threshold); //insert into data structure containing captured anomalies
           n_outliers += 1;
 
@@ -687,9 +686,8 @@ unsigned long ADOutlierCOPOD::compute_outliers(Anomalies &outliers,
         //Capture maximum of one normal execution per io step
         itt->set_label(1);
         if(outliers.nFuncEvents(func_id, Anomalies::EventType::Normal) == 0) {
-      	   std::cout << "Detected normal event on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
-      	   outliers.insert(itt, Anomalies::EventType::Normal);
-
+	  verboseStream << "Detected normal event on func id " << func_id << " (" << itt->get_funcname() << ") on thread " << itt->get_tid() << " runtime " << runtime_i << std::endl;
+	  outliers.insert(itt, Anomalies::EventType::Normal);
         }
 
       }

test/unit_tests/ad/HBOSOutlierTestBPFile.cpp

@@ -9,6 +9,7 @@
 #include <nlohmann/json.hpp>
 #include "gtest/gtest.h"
 #include "../unit_test_common.hpp"
+#include "../unit_test_cmdline.hpp"
 
 #include<thread>
 #include<chrono>
@@ -92,7 +93,12 @@ void create_save_json(const std::unordered_map<unsigned long, std::vector<std::v
 }
 
 TEST(HBOSADOutlierBPFileWithoutPServer, Works) {
-
+  //Get trace data dir from command line
+  if(_argc < 2){
+    throw std::runtime_error("Path to trace data directory must be provided as an argument!");
+  }
+  std::string trace_data_dir = _argv[1];
+  
   int ranks = 4;
   std::vector<int> v_io_steps(ranks);
   std::vector<int> v_functions(ranks);
@@ -108,7 +114,7 @@ TEST(HBOSADOutlierBPFileWithoutPServer, Works) {
     ChimbukoParams params;
     //Parameters for the connection to the instrumented binary trace output
     params.trace_engineType = "BPFile";  // BPFile or SST
-    params.trace_data_dir = "<PATH>/test/data"; //ad/test/data";  // *.bp location
+    params.trace_data_dir = trace_data_dir; // *.bp location
     std::string bp_prefix = "tau-metrics";  // bp file prefix (e.g. tau-metrics-[nwchem])
 
     //The remainder are optional arguments. Enable using the appropriate command line switch

test/unit_tests/ad/SSTDOutlierTestBPFile.cpp

@@ -7,6 +7,7 @@
 #include<chimbuko/message.hpp>
 #include "gtest/gtest.h"
 #include "../unit_test_common.hpp"
+#include "../unit_test_cmdline.hpp"
 
 #include<thread>
 #include<chrono>
@@ -92,6 +93,12 @@ void create_save_json(const std::unordered_map<unsigned long, std::vector<double
 }
 
 TEST(SSTDADOutlierBPFileWithoutPServer, Works) {
+  //Get trace data dir from command line
+  if(_argc < 2){
+    throw std::runtime_error("Path to trace data directory must be provided as an argument!");
+  }
+  std::string trace_data_dir = _argv[1];
+
   //int file_suffix = 1;
   int ranks = 4;
   std::vector<int> v_io_steps(ranks);
@@ -108,7 +115,7 @@ TEST(SSTDADOutlierBPFileWithoutPServer, Works) {
     ChimbukoParams params;
     //Parameters for the connection to the instrumented binary trace output
     params.trace_engineType = "BPFile"; // argv[1]; // BPFile or SST
-    params.trace_data_dir = "<PATH>/test/data"; // argv[2]; // *.bp location
+    params.trace_data_dir = trace_data_dir; // *.bp location
     std::string bp_prefix = "tau-metrics"; //argv[3]; // bp file prefix (e.g. tau-metrics-[nwchem])
 
     //The remainder are optional arguments. Enable using the appropriate command line switch

test/unit_tests/run_all.sh

@@ -21,6 +21,13 @@ set -o pipefail
 ./ad/ADcombinedPSdata
 ./ad/FuncAnomalyMetrics
 ./ad/ADLocalAnomalyMetrics
+./ad/HBOSOutlierDistributions
+./ad/HBOSOutlier
+./ad/HBOSOutlierADs
+./ad/HBOSOutlierTestBPFile ../data
+./ad/SSTDOutlierTestBPFile ../data
+./ad/COPODOutlier
+./ad/COPODOutlierADs
 ./util/DispatchQueue
 ./util/commandLineParser
 ./util/RunStats