modified unit tests and HBOS/COPOD execDataMap function iteration

Author: Sandeep Mittal

src/ad/ADOutlier.cpp

@@ -267,15 +267,15 @@ Anomalies ADOutlierHBOS::run(int step) {
     if (runtimes.size() > 0) {
       if (!g.find(func_id)) { // If func_id does not exist
         const int r = param[func_id].create_histogram(runtimes);
-        if (r < 0) {return outliers;}
+        if (r < 0) {continue;}
       }
       else { //merge with exisiting func_id, not overwrite
 
         const int r = param[func_id].merge_histograms(g[func_id], runtimes);
-	if (r < 0) {return outliers;}
+	if (r < 0) {continue;}
       }
     }
-    else { return outliers;}
+    else { continue;}
   }
 
   //Update temp runstats to include information collected previously (synchronizes with the parameter server if connected)
@@ -543,15 +543,15 @@ Anomalies ADOutlierCOPOD::run(int step) {
     if (runtimes.size() > 0) {
       if (!g.find(func_id)) { // If func_id does not exist
         const int r = param[func_id].create_histogram(runtimes);
-        if (r < 0) {return outliers;}
+        if (r < 0) {continue;}
       }
       else { //merge with exisiting func_id, not overwrite
 
         const int r = param[func_id].merge_histograms(g[func_id], runtimes);
-	if (r < 0) {return outliers;}
+	if (r < 0) {continue;}
       }
     }
-    else { return outliers;}
+    else { continue;}
   }
 
   //Update temp runstats to include information collected previously (synchronizes with the parameter server if connected)

test/unit_tests/ad/HBOSOutlierTestBPFile.cpp

@@ -115,7 +115,7 @@ TEST(HBOSADOutlierBPFileWithoutPServer, Works) {
     //Parameters for the connection to the instrumented binary trace output
     params.trace_engineType = "BPFile";  // BPFile or SST
     params.trace_data_dir = trace_data_dir; // *.bp location
-    std::string bp_prefix = "tau-metrics";  // bp file prefix (e.g. tau-metrics-[nwchem])
+    std::string bp_prefix = "tau-metrics-xgc-es-cpp-gpu"; //"tau-metrics";  // bp file prefix (e.g. tau-metrics-[nwchem])
 
     //The remainder are optional arguments. Enable using the appropriate command line switch
     params.program_idx = 0;
@@ -128,7 +128,7 @@ TEST(HBOSADOutlierBPFileWithoutPServer, Works) {
     params.prov_outputpath = "";
   #ifdef ENABLE_PROVDB
     params.nprovdb_shards = 1;
-    params.provdb_addr = ""; //don't use provDB by default
+    params.provdb_addr = ""; //don't use provDB 
   #endif
     params.err_outputpath = ""; //use std::cerr for errors by default
     params.trace_connect_timeout = 60;

test/unit_tests/ad/SSTDOutlierTestBPFile.cpp

@@ -97,7 +97,7 @@ TEST(SSTDADOutlierBPFileWithoutPServer, Works) {
   if(_argc < 2){
     throw std::runtime_error("Path to trace data directory must be provided as an argument!");
   }
-  std::string trace_data_dir = _argv[1];
+  std::string trace_data_dir = _argv[1]; //"/home/src/chimbuko_ad/96rank_98step_traces_11_8_21/"; //_argv[1];
 
   //int file_suffix = 1;
   int ranks = 4;
@@ -116,7 +116,7 @@ TEST(SSTDADOutlierBPFileWithoutPServer, Works) {
     //Parameters for the connection to the instrumented binary trace output
     params.trace_engineType = "BPFile"; // argv[1]; // BPFile or SST
     params.trace_data_dir = trace_data_dir; // *.bp location
-    std::string bp_prefix = "tau-metrics"; //argv[3]; // bp file prefix (e.g. tau-metrics-[nwchem])
+    std::string bp_prefix = "tau-metrics-xgc-es-cpp-gpu"; //"tau-metrics"; //argv[3]; // bp file prefix (e.g. tau-metrics-[nwchem])
 
     //The remainder are optional arguments. Enable using the appropriate command line switch
     params.program_idx = 0;