Skip to content

Commit ebb2e65

Browse files
committed
Fixed ADOutlier unit tests failing in string comparison of binary serialized data. Instead we unserialize the object and compare after. Improved related tests to check state of test comparison object.
1 parent 64bf5bd commit ebb2e65

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

test/unit_tests/ad/ADOutlier.cpp

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,24 @@ TEST(ADOutlierTestSyncParamWithoutPS, Works){
9696

9797
std::cout << local_params_ps_in[0].get_json().dump();
9898

99+
EXPECT_EQ(local_params_ps.get_runstats().size(), 1);
100+
EXPECT_EQ(local_params_ps.get_runstats().begin()->second, local_params_ps_in.begin()->second);
101+
99102
ADOutlierSSTDTest outlier;
100103
outlier.sync_param_test(&local_params_ps);
101104

102105
//internal copy should be equal to global copy
103-
std::string in_state = outlier.get_global_parameters()->serialize();
106+
SstdParam const* glob_params = dynamic_cast<SstdParam const*>(outlier.get_global_parameters());
104107

105-
EXPECT_EQ(local_params_ps.serialize(), in_state);
108+
EXPECT_EQ(glob_params->get_runstats(), local_params_ps.get_runstats());
109+
110+
//Check serialization
111+
std::string glob_params_ser = glob_params->serialize();
112+
113+
SstdParam glob_params_unser;
114+
glob_params_unser.assign(glob_params_ser);
115+
116+
EXPECT_EQ(glob_params_unser.get_runstats(), local_params_ps.get_runstats());
106117
}
107118

108119

0 commit comments

Comments
 (0)