Skip to content

Commit 49ed84a

Browse files
committed
make types more stricter
1 parent 8fefff4 commit 49ed84a

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

src/types.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
export type Dpr = '1x' | '2x' | '3x';
22

33
export type CompressionRatio = {
4-
[dpr in Dpr]?: number;
4+
"1x": number;
5+
"2x"?: number;
6+
"3x"?: number;
57
}
68

79
export type SrcSet = {
8-
[dpr in Dpr]?: string;
10+
"1x": string;
11+
"2x"?: string;
12+
"3x"?: string;
913
};
1014

1115
export type ExtensionSrcSet = {

src/utils/getCompressionRatio.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ import { Dpr, CompressionRatio } from '../types'
55
export const getCompressionRatio = (pixelRatios: Dpr[]): CompressionRatio => {
66
const length = pixelRatios.length;
77

8-
return pixelRatios.reduce((acc: CompressionRatio, item: Dpr, index: number) => {
8+
return pixelRatios.reduce((acc, item, index) => {
99
if (index + 1 === length) {
1010
acc[item]= 0
1111
return acc
1212
}
1313

1414
acc[item] = (index + 1) / length
1515
return acc
16-
},{})
16+
},{} as CompressionRatio)
1717
}

src/webpack/imgproxyUrlBuilder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ export const getImgproxyUrlBuilder = ({
2828
return (pixelRatios: Dpr[], imagePath: string, extension: string): SrcSet => {
2929
const compressionsRatio = getCompressionRatio(pixelRatios)
3030

31-
return pixelRatios.reduce((acc:SrcSet, item: Dpr) => {
31+
return pixelRatios.reduce((acc, item) => {
3232
acc[item] = buildImgproxyUrl(imagePath, compressionsRatio[item] || 0, extension)
3333
return acc
34-
},{})
34+
}, {} as SrcSet)
3535
}
3636
};

0 commit comments

Comments
 (0)