get rid of scope cloning when an error occurs in a union operation

it's redundant as the way upvalues are tracked does a better job

Author: CapsAdmin

nattlua/analyzer/base/scopes.lua

@@ -76,18 +76,6 @@ return function(META)
 		return self.scope_stack
 	end
 
-	function META:CloneCurrentScope()
-		local scope_copy = self:GetScope():Copy()
-		local g = self:GetGlobalEnvironment("runtime"):Copy()
-		local last_node = self:GetContextValue("global_environment_nodes")
-		self:PopScope()
-		self:PopGlobalEnvironment("runtime")
-		scope_copy:SetParent(scope_copy:GetParent() or self:GetScope())
-		self:PushGlobalEnvironment(last_node, g, "runtime")
-		self:PushScope(scope_copy)
-		return scope_copy
-	end
-
 	function META:IncrementUpvaluePosition()
 		self.upvalue_position = (self.upvalue_position or 0) + 1
 		return self.upvalue_position

nattlua/analyzer/control_flow.lua

@@ -376,12 +376,6 @@ return function(META)
 		return scope
 	end
 
-	function META:ErrorAndCloneCurrentScope(err)
-		self:Error(err)
-		self:CloneCurrentScope()
-		self:GetScope():SetConditionalScope(true)
-	end
-
 	function META:PopConditionalScope()
 		self:PopScope()
 	end

nattlua/analyzer/operators/binary.lua

@@ -332,18 +332,8 @@ local function Binary(self, node, l, r, op)
 					local res, err = Binary(self, node, l, r, op)
 
 					if not res then
-						if type(err) == "string" then
-							print(node, l,r,op)
-							print(res, err, "?!?!!!")
-						end
-						self:ErrorAndCloneCurrentScope(err, l) -- TODO, only left side?
+						self:Error(err)
 					else
-						if type(res) ~= "table" then
-							print(res, err, l,op, r)
-							debug.trace()
-							error("HUH")
-						end
-						
 						if res:IsTruthy() then
 							if type_checked then
 								for _, t in ipairs(type_checked:GetData()) do

nattlua/analyzer/operators/call.lua

@@ -23,7 +23,7 @@ local function union_call(self, analyzer, input, call_node)
 			end
 
 			if v.Type ~= "function" and v.Type ~= "table" and v.Type ~= "any" then
-				analyzer:ErrorAndCloneCurrentScope(type_errors.union_contains_non_callable(self, v), self--[[# as any]])
+				analyzer:Error(type_errors.union_contains_non_callable(self, v))
 			else
 				truthy_union:AddType(v)
 			end

nattlua/analyzer/operators/prefix.lua

@@ -49,8 +49,7 @@ local function Prefix(analyzer, node, r)
 			local res, err = Prefix(analyzer, node, r)
 
 			if not res then
-				analyzer:ErrorAndCloneCurrentScope(err, r)
-				falsy_union:AddType(r)
+				analyzer:Error(err)
 			else
 				new_union:AddType(res)