Skip to content

Commit 5b22e90

Browse files
committed
Fix Firefox WASM crash on input components & Some More Sync Changes
1 parent 3b79218 commit 5b22e90

6 files changed

Lines changed: 47 additions & 27 deletions

File tree

docs/CodeBeam.MudBlazor.Extensions.Docs.Wasm/wwwroot/CodeBeam.MudBlazor.Extensions.xml

Lines changed: 38 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/CodeBeam.MudBlazor.Extensions/Components/InputExtended/MudInputExtended.razor

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
@onblur="@OnBlurredAsync"
3131
@onkeydown="@InvokeKeyDownAsync"
3232
@onkeyup="@InvokeKeyUpAsync"
33-
@onbeforeinput="@InvokeBeforeInputAsync"
3433
@onpaste="@OnPaste"
3534
maxlength="@MaxLength"
3635
@onkeydown:preventDefault="@KeyDownPreventDefault"
@@ -75,7 +74,6 @@
7574
pattern="@Pattern"
7675
@onkeydown="@InvokeKeyDownAsync"
7776
@onkeyup="@InvokeKeyUpAsync"
78-
@onbeforeinput="@InvokeBeforeInputAsync"
7977
maxlength="@MaxLength"
8078
@onkeydown:preventDefault="KeyDownPreventDefault"
8179
@onkeyup:preventDefault="@KeyUpPreventDefault"
@@ -105,7 +103,6 @@
105103
pattern="@Pattern"
106104
@onkeydown="@InvokeKeyDownAsync"
107105
@onkeyup="@InvokeKeyUpAsync"
108-
@onbeforeinput="@InvokeBeforeInputAsync"
109106
maxlength="@MaxLength"
110107
@onkeydown:preventDefault="KeyDownPreventDefault"
111108
@onkeyup:preventDefault="@KeyUpPreventDefault"

src/CodeBeam.MudBlazor.Extensions/Components/SelectExtended/MudSelectExtended.razor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ public MudSelectExtended()
8585
.AddClass("mud-select-extended-nowrap mud-chip-scroll-container", NoWrap)
8686
.Build();
8787

88-
private string _elementId = "select_" + Guid.NewGuid().ToString().Substring(0, 8);
89-
private string _popoverId = "selectpopover_" + Guid.NewGuid().ToString().Substring(0, 8);
88+
private string _elementId = Identifier.Create("selectext");
89+
private string _popoverId = Identifier.Create("selectpopover_");
9090

9191
/// <summary>
9292
/// User class names for the input, separated by space

src/CodeBeam.MudBlazor.Extensions/Components/SelectExtended/MudSelectItemExtended.razor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public partial class MudSelectItemExtended<T> : MudComponentBase, IDisposable
2020
///
2121
/// </summary>
2222
public MudListItemExtended<T> ListItem { get; set; } = new();
23-
internal string ItemId { get; } = "selectItem_"+Guid.NewGuid().ToString().Substring(0,8);
23+
internal string ItemId { get; } = Identifier.Create("selectItem_");
2424

2525
private IMudShadowSelectExtended? _shadowParent;
2626
/// <summary>

src/CodeBeam.MudBlazor.Extensions/Components/TextFieldExtended/MudTextFieldExtended.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
@typeparam T
33
@inherits MudDebouncedInputExtended<T>
44

5-
<CascadingValue Name="SubscribeToParentForm2" Value="@SubscribeToParentForm2" IsFixed="true">
5+
<CascadingValue Name="SubscribeToParentForm" Value="@SubscribeToParentForm" IsFixed="true">
66
<MudInputControl Label="@Label"
77
Variant="@Variant"
88
HelperText="@HelperText"
@@ -18,7 +18,7 @@
1818
Required="@Required"
1919
ForId="@InputElementId">
2020
<InputContent>
21-
<CascadingValue Name="SubscribeToParentForm2" Value="false" IsFixed="true">
21+
<CascadingValue Name="SubscribeToParentForm" Value="false" IsFixed="true">
2222
@if (_mask == null)
2323
{
2424
<MudInputExtended T="string"

src/CodeBeam.MudBlazor.Extensions/Components/TextFieldExtended/MudTextFieldExtended.razor.cs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,10 @@ public partial class MudTextFieldExtended<T> : MudDebouncedInputExtended<T>
1515
///
1616
/// </summary>
1717
protected string? Classname =>
18-
new CssBuilder("mud-input-input-control")
19-
.AddClass("mud-no-start-adornment", AdornmentStart == null)
20-
.AddClass(Class)
21-
.Build();
22-
23-
/// <summary>
24-
///
25-
/// </summary>
26-
[CascadingParameter]
27-
public bool SubscribeToParentForm2 { get; set; }
18+
new CssBuilder("mud-input-input-control")
19+
.AddClass("mud-no-start-adornment", AdornmentStart == null)
20+
.AddClass(Class)
21+
.Build();
2822

2923
/// <summary>
3024
///

0 commit comments

Comments
 (0)