refactor!: set clippy avoid-breaking-exported-api = false (oxc-project#519)

Author: Boshen

.clippy.toml

@@ -0,0 +1 @@
+avoid-breaking-exported-api = false

src/cache.rs

@@ -93,7 +93,7 @@ pub trait CachedPath: Sized {
     /// Returns a new path by resolving the given subpath (including "." and
     /// ".." components) with this path.
     #[must_use]
-    fn normalize_with<C: Cache<Cp = Self>>(&self, subpath: impl AsRef<Path>, cache: &C) -> Self;
+    fn normalize_with<C: Cache<Cp = Self>, P: AsRef<Path>>(&self, subpath: P, cache: &C) -> Self;
 
     #[must_use]
     fn normalize_root<C: Cache<Cp = Self>>(&self, _cache: &C) -> Self;

src/error.rs

@@ -70,7 +70,7 @@ pub enum ResolveError {
 
     /// JSON parse error
     #[error("{0:?}")]
-    JSON(JSONError),
+    Json(JSONError),
 
     /// Restricted by `ResolveOptions::restrictions`
     #[error(r#"Path "{0}" restricted by {0}"#)]
@@ -114,7 +114,7 @@ impl ResolveError {
     #[must_use]
     #[cfg(feature = "fs_cache")]
     pub fn from_serde_json_error(path: PathBuf, error: &serde_json::Error) -> Self {
-        Self::JSON(JSONError {
+        Self::Json(JSONError {
             path,
             message: error.to_string(),
             line: error.line(),

src/fs_cache.rs

@@ -346,7 +346,7 @@ impl CachedPath for FsCachedPath {
     ///
     /// # Errors
     ///
-    /// * [ResolveError::JSON]
+    /// * [ResolveError::Json]
     fn find_package_json<C: Cache<Cp = Self>>(
         &self,
         options: &ResolveOptions,
@@ -399,7 +399,7 @@ impl CachedPath for FsCachedPath {
     }
 
     /// Returns a new path by resolving the given subpath (including "." and ".." components) with this path.
-    fn normalize_with<C: Cache<Cp = Self>>(&self, subpath: impl AsRef<Path>, cache: &C) -> Self {
+    fn normalize_with<C: Cache<Cp = Self>, P: AsRef<Path>>(&self, subpath: P, cache: &C) -> Self {
         let subpath = subpath.as_ref();
         let mut components = subpath.components();
         let Some(head) = components.next() else { return cache.value(subpath) };

src/options.rs

@@ -374,7 +374,7 @@ impl ResolveOptions {
 }
 
 /// Value for [ResolveOptions::enforce_extension]
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 pub enum EnforceExtension {
     Auto,
     Enabled,
@@ -383,17 +383,17 @@ pub enum EnforceExtension {
 
 impl EnforceExtension {
     #[must_use]
-    pub const fn is_auto(&self) -> bool {
+    pub const fn is_auto(self) -> bool {
         matches!(self, Self::Auto)
     }
 
     #[must_use]
-    pub const fn is_enabled(&self) -> bool {
+    pub const fn is_enabled(self) -> bool {
         matches!(self, Self::Enabled)
     }
 
     #[must_use]
-    pub const fn is_disabled(&self) -> bool {
+    pub const fn is_disabled(self) -> bool {
         matches!(self, Self::Disabled)
     }
 }

src/tests/incorrect_description_file.rs

@@ -10,7 +10,7 @@ fn incorrect_description_file_1() {
     let f = super::fixture().join("incorrect-package");
     let mut ctx = ResolveContext::default();
     let resolution = Resolver::default().resolve_with_context(f.join("pack1"), ".", &mut ctx);
-    let error = ResolveError::JSON(JSONError {
+    let error = ResolveError::Json(JSONError {
         path: f.join("pack1/package.json"),
         message: String::from("EOF while parsing a value at line 3 column 0"),
         line: 3,
@@ -29,7 +29,7 @@ fn incorrect_description_file_1() {
 fn incorrect_description_file_2() {
     let f = super::fixture().join("incorrect-package");
     let resolution = Resolver::default().resolve(f.join("pack2"), ".");
-    let error = ResolveError::JSON(JSONError {
+    let error = ResolveError::Json(JSONError {
         path: f.join("pack2/package.json"),
         message: String::from("EOF while parsing a value at line 1 column 0"),
         line: 1,

src/tests/tsconfig_paths.rs

@@ -120,7 +120,7 @@ fn broken() {
     });
 
     let resolved_path = resolver.resolve(&f, "/");
-    let error = ResolveError::JSON(JSONError {
+    let error = ResolveError::Json(JSONError {
         path: f.join("tsconfig_broken.json"),
         message: String::from("EOF while parsing an object at line 2 column 0"),
         line: 2,