Skip to content

Commit 5ab7722

Browse files
refactor(Wind): Replace hand-written types with re-exports from VS Code source
Swap out hand-written TypeScript type definitions for re-exports from the real VS Code source in @codeeditorland/output. This affects: - **VSCodeWorkbenchOptionsType**: IVSCodeWorkbenchOptions now aliases IWorkbenchConstructionOptions from web.api.js (the authoritative 668-line interface). Supporting types (IWorkspaceProvider, ITunnelProvider, etc.) re-exported from their canonical VS Code locations. - **VSCodeConfigurationType**: ConfigurationTarget enum and Event/IDisposable types sourced from VS Code extHostTypes. - **VSCodeLoggerType**: LogLevel enum re-exported from VS Code (previously had inverted values: Trace=0..Off=6 vs VS Code's Off=0..Trace=1). - **FileType**: FileType enum re-exported from vs/platform/files/common/files.js. - **URI**: Full URI class re-exported from vs/base/common/uri.js. The hand-written version had fsPath as a method (wrong shape) and was missing with(), toJSON(), revive() methods. - **IStat**: File metadata interface now sourced from VS Code. Also fix a bug in FileSystemProviderImplementation where uri.fsPath() was called as a method when it's actually a getter on the real VS Code URI. ESBuild config files in Configuration/ESBuild/ are reformatted for consistency with recent commits.
1 parent 15bf4f9 commit 5ab7722

29 files changed

Lines changed: 294 additions & 1167 deletions

Configuration/ESBuild/Config/BaseConfig.js

Lines changed: 48 additions & 51 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/Config/CompileConfig.js

Lines changed: 13 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/Config/TargetConfig.js

Lines changed: 40 additions & 50 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/Constant/BoundConstant.js

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/Constant/EnvironmentConstant.js

Lines changed: 7 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/Constant/PathConstant.js

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/Target.js

Lines changed: 9 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/Wind.js

Lines changed: 8 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configuration/ESBuild/index.js

Lines changed: 8 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)