Updated the settings view

Author: thedillonb

CodeHub.Core/ViewModels/App/SettingsViewModel.cs

@@ -61,6 +61,7 @@ private async Task RegisterPushNotifications(bool enabled)
 				else
 					await Task.Run(() => notificationService.Deregister());
 				this.GetApplication().Account.PushNotificationsEnabled = enabled;
+				this.GetApplication().Accounts.Update(this.GetApplication().Account);
 				RaisePropertyChanged(() => PushNotificationsEnabled);
 			}
 			catch (Exception e)

CodeHub.iOS/Views/App/SettingsView.cs

@@ -25,63 +25,56 @@ private void CreateTable()
 		{
 			var application = Mvx.Resolve<IApplicationService>();
 			var vm = (SettingsViewModel)ViewModel;
-			var root = new RootElement(Title);
 			var currentAccount = application.Account;
 
-			root.Add(new Section(string.Empty, "If disabled, CodeHub will prompt you for your password when you switch to this account") {
-				new TrueFalseElement("Push Notifications".t(), vm.PushNotificationsEnabled, e => vm.PushNotificationsEnabled = e.Value)
-			});
-
-			root.Add(new Section(string.Empty, "If disabled, CodeHub will prompt you for your password when you switch to this account".t()) {
-				new TrueFalseElement("Remember Credentials".t(), !currentAccount.DontRemember, e => { 
-					currentAccount.DontRemember = !e.Value;
-					application.Accounts.Update(currentAccount);
-				})
+			var saveCredentials = new TrueFalseElement("Save Credentials".t(), !currentAccount.DontRemember, e =>
+			{ 
+				currentAccount.DontRemember = !e.Value;
+				application.Accounts.Update(currentAccount);
 			});
 
-			root.Add(new Section(string.Empty, "If enabled, your teams will be shown in the CodeHub slideout menu under Events".t()) {
-				new TrueFalseElement("Show Organizations in Events".t(), currentAccount.ShowOrganizationsInEvents, e => { 
-					currentAccount.ShowOrganizationsInEvents = e.Value;
-					application.Accounts.Update(currentAccount);
-				})
+			var showOrganizationsInEvents = new TrueFalseElement("Show Organizations in Events".t(), currentAccount.ShowOrganizationsInEvents, e =>
+			{ 
+				currentAccount.ShowOrganizationsInEvents = e.Value;
+				application.Accounts.Update(currentAccount);
 			});
 
-			root.Add(new Section(string.Empty, "If enabled, every organization will be listed under Organizations".t()) {
-				new TrueFalseElement("List Organizations".t(), currentAccount.ExpandOrganizations, e => { 
-					currentAccount.ExpandOrganizations = e.Value;
-					application.Accounts.Update(currentAccount);
-				})
+			var showOrganizations = new TrueFalseElement("List Organizations in Menu".t(), currentAccount.ExpandOrganizations, e =>
+			{ 
+				currentAccount.ExpandOrganizations = e.Value;
+				application.Accounts.Update(currentAccount);
 			});
 
-			root.Add(new Section(string.Empty, "If enabled, repository descriptions will be shown in the list of repositories".t()) {
-				new TrueFalseElement("Show Repo Descriptions".t(), currentAccount.ShowRepositoryDescriptionInList, e => { 
-					currentAccount.ShowRepositoryDescriptionInList = e.Value;
-					application.Accounts.Update(currentAccount);
-				})
+			var repoDescriptions = new TrueFalseElement("Show Repo Descriptions".t(), currentAccount.ShowRepositoryDescriptionInList, e =>
+			{ 
+				currentAccount.ShowRepositoryDescriptionInList = e.Value;
+				application.Accounts.Update(currentAccount);
 			});
 
-			var el = new StyledStringElement("Startup View", vm.DefaultStartupViewName, MonoTouch.UIKit.UITableViewCellStyle.Value1)
+			var startupView = new StyledStringElement("Startup View", vm.DefaultStartupViewName, MonoTouch.UIKit.UITableViewCellStyle.Value1)
 			{ 
 				Accessory = MonoTouch.UIKit.UITableViewCellAccessory.DisclosureIndicator,
 			};
-			el.Tapped += () => vm.GoToDefaultStartupViewCommand.Execute(null);
-			root.Add(new Section(string.Empty, "Select the default startup view after login".t()) { el });
+			startupView.Tapped += () => vm.GoToDefaultStartupViewCommand.Execute(null);
 
-			root.Add(new Section(string.Empty, "If enabled, send anonymous usage statistics to build a better app".t()) {
-				new TrueFalseElement("Send Anonymous Usage".t(), vm.AnalyticsEnabled, e => vm.AnalyticsEnabled = e.Value)
-			});
+			var pushNotifications = new TrueFalseElement("Push Notifications".t(), vm.PushNotificationsEnabled, e => vm.PushNotificationsEnabled = e.Value);
 
 			var totalCacheSizeMB = vm.CacheSize.ToString("0.##");
-			var cacheSection = new Section(string.Empty, string.Format("{0} MB of cache used".t(), totalCacheSizeMB)); 
-			cacheSection.Add(new StyledStringElement("Delete Cache".t(), () =>
-				{ 
-					vm.DeleteAllCacheCommand.Execute(null);
-					cacheSection.Footer = string.Format("{0} MB of cache used".t(), 0);
-					ReloadData();
-				}));
-			root.Add(cacheSection);
+			var deleteCache = new StyledStringElement("Delete Cache".t(), string.Format("{0} MB of cache used".t(), totalCacheSizeMB), MonoTouch.UIKit.UITableViewCellStyle.Subtitle);
+			deleteCache.Tapped += () =>
+			{ 
+				vm.DeleteAllCacheCommand.Execute(null);
+				deleteCache.Value = string.Format("{0} MB of cache used".t(), 0);
+				ReloadData();
+			};
+
+			var usage = new TrueFalseElement("Send Anonymous Usage".t(), vm.AnalyticsEnabled, e => vm.AnalyticsEnabled = e.Value);
 
 			//Assign the root
+			var root = new RootElement(Title);
+			root.Add(new Section("Account") { saveCredentials, pushNotifications });
+			root.Add(new Section("Apperance") { showOrganizationsInEvents, showOrganizations, repoDescriptions, startupView });
+			root.Add(new Section ("Internal") { deleteCache, usage });
 			Root = root;
 
 		}