Skip to content

Commit 6530bab

Browse files
committed
ci: update to current GitHub-hosted runner images
ubuntu-20.04 and windows-2019 were removed from GitHub Actions and will never pick up jobs. Also simplify clang-tidy installation since the new Ubuntu image ships a recent enough version in default repos.
1 parent c77ad94 commit 6530bab

3 files changed

Lines changed: 11 additions & 17 deletions

File tree

.github/workflows/release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
name: create prebuilds
1212
strategy:
1313
matrix:
14-
os: [ubuntu-20.04, macos-latest, windows-2019]
14+
os: [ubuntu-latest, macos-latest, windows-latest]
1515
opts: [""]
1616
include:
1717
- os: macos-latest
@@ -44,7 +44,7 @@ jobs:
4444
release:
4545
name: release
4646
needs: [prebuilds]
47-
runs-on: ubuntu-20.04
47+
runs-on: ubuntu-latest
4848
permissions:
4949
contents: write # for creating releases
5050
steps:

.github/workflows/run-all-tests-main.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ jobs:
1414
runs-on: ${{ matrix.os }}
1515
strategy:
1616
matrix:
17-
os: [windows-2019, ubuntu-20.04, macos-latest]
17+
os: [windows-latest, ubuntu-latest, macos-latest]
1818
node: [16]
1919
include:
2020
# Test LTS versions on main
2121
# 18 on Ubuntu is sufficient, and 20 already tested in PR
22-
- os: ubuntu-20.04
22+
- os: ubuntu-latest
2323
node: 18
2424
steps:
2525
- name: checkout
@@ -52,7 +52,7 @@ jobs:
5252
run: npm run test
5353
fuzz_tests:
5454
name: fuzz tests
55-
runs-on: ubuntu-20.04
55+
runs-on: ubuntu-latest
5656
steps:
5757
- name: checkout
5858
uses: actions/checkout@v3
@@ -81,7 +81,7 @@ jobs:
8181
run: node fuzztests/runFuzzTests.js
8282
end-to-end:
8383
name: end-to-end
84-
runs-on: ubuntu-20.04
84+
runs-on: ubuntu-latest
8585
steps:
8686
- name: checkout
8787
uses: actions/checkout@v3

.github/workflows/run-all-tests-pr.yaml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ concurrency:
1111
jobs:
1212
linting:
1313
name: lint
14-
runs-on: ubuntu-20.04
14+
runs-on: ubuntu-latest
1515
steps:
1616
- name: checkout
1717
uses: actions/checkout@v3
@@ -22,14 +22,8 @@ jobs:
2222
cache: "npm"
2323
- name: install dependencies
2424
run: npm ci
25-
- name: install dependencies with apt
26-
run: |
27-
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
28-
sudo apt-get install software-properties-common
29-
sudo add-apt-repository 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-16 main'
30-
sudo apt-get install clang-tidy-16
31-
sudo rm -f /usr/bin/clang-tidy
32-
sudo ln -s /usr/bin/clang-tidy-16 /usr/bin/clang-tidy
25+
- name: install clang-tidy
26+
run: sudo apt-get install -y clang-tidy
3327
- name: build project
3428
# Build project so that imports can be checked during linting
3529
run: npm run build
@@ -44,7 +38,7 @@ jobs:
4438
runs-on: ${{ matrix.os }}
4539
strategy:
4640
matrix:
47-
os: [windows-2019, ubuntu-20.04, macos-latest]
41+
os: [windows-latest, ubuntu-latest, macos-latest]
4842
# Test only latest LTS version in PRs
4943
node: [20]
5044
steps:
@@ -83,7 +77,7 @@ jobs:
8377
permissions:
8478
pull-requests: write
8579
contents: write
86-
runs-on: ubuntu-20.04
80+
runs-on: ubuntu-latest
8781
if: ${{ github.actor == 'dependabot[bot]' }}
8882
steps:
8983
- name: Dependabot metadata

0 commit comments

Comments
 (0)