Skip to content

Commit e44a1f0

Browse files
committed
fix: resolve all remaining lint issues for CI
- Remove unused _androidAppId field from launch_review_service - Replace deprecated withOpacity() with withValues(alpha:) - Ignore parameter_assignments lint in ffmpeg_kit_service (intentional design)
1 parent 6fdb367 commit e44a1f0

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

lib/src/core/services/ffmpeg_kit_service/ffmpeg_kit_service.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a GPL-style license that can be found
33
// in the LICENSE file.
44

5-
// ignore_for_file: lines_longer_than_80_chars
5+
// ignore_for_file: lines_longer_than_80_chars, parameter_assignments
66

77
import 'dart:async';
88
import 'dart:developer';

lib/src/core/services/launch_review_service/launch_review_service.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@ class LaunchReviewService {
1919
const LaunchReviewService({
2020
String? androidAppId,
2121
String? iOSAppId,
22-
}) : _androidAppId = androidAppId,
23-
_iOSAppId = iOSAppId;
22+
}) : _iOSAppId = iOSAppId;
2423

25-
final String? _androidAppId;
2624
final String? _iOSAppId;
2725

2826
/// Launches the app store page for this app.

lib/src/presentation/more/view/widgets/copyright_widget.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class _CopyrightWidget extends StatelessWidget {
3939
'Based on VSound by BBK Development',
4040
style: context.textTheme.bodySmall?.copyWith(
4141
fontSize: 10,
42-
color: context.textTheme.bodySmall?.color?.withOpacity(0.7),
42+
color: context.textTheme.bodySmall?.color?.withValues(alpha: 0.7),
4343
),
4444
textAlign: TextAlign.center,
4545
),
@@ -48,7 +48,7 @@ class _CopyrightWidget extends StatelessWidget {
4848
'Open Source (GPL v3) • github.com/CodeShipping/AV-Editor',
4949
style: context.textTheme.bodySmall?.copyWith(
5050
fontSize: 10,
51-
color: context.textTheme.bodySmall?.color?.withOpacity(0.7),
51+
color: context.textTheme.bodySmall?.color?.withValues(alpha: 0.7),
5252
),
5353
textAlign: TextAlign.center,
5454
),

0 commit comments

Comments
 (0)