Skip to content

Commit a10e8c0

Browse files
gotta fix memory leak
1 parent 8df2b66 commit a10e8c0

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

buildnumber.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2058
1+
2060

source/funkin/game/PlayState.hx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1436,12 +1436,11 @@ class PlayState extends MusicBeatState
14361436
}
14371437

14381438
var notePerStrum = [for(i in 0...4) null];
1439-
var additionalNotes:Array<Note> = [];
14401439
if (__justPressed.contains(true)) {
14411440
__funcsToExec.push(function(note:Note) {
14421441
if (__justPressed[note.strumID] && !note.isSustainNote && note.mustPress && !note.wasGoodHit && note.canBeHit) {
14431442
if (notePerStrum[note.strumID] == null) notePerStrum[note.strumID] = note;
1444-
else if (Math.abs(notePerStrum[note.strumID].strumTime - note.strumTime) <= 10) additionalNotes.push(note);
1443+
else if (Math.abs(notePerStrum[note.strumID].strumTime - note.strumTime) <= 5) deleteNote(note);
14451444
else if (note.strumTime < notePerStrum[note.strumID].strumTime) notePerStrum[note.strumID] = note;
14461445
}
14471446
});
@@ -1454,7 +1453,6 @@ class PlayState extends MusicBeatState
14541453
}
14551454

14561455
for(e in notePerStrum) if (e != null) goodNoteHit(e);
1457-
for(e in additionalNotes) goodNoteHit(e);
14581456

14591457
playerStrums.forEach(function(str:Strum) {
14601458
str.updatePlayerInput(__pressed[str.ID], __justPressed[str.ID], __justReleased[str.ID]);
@@ -1539,8 +1537,7 @@ class PlayState extends MusicBeatState
15391537

15401538
var event:NoteHitEvent;
15411539
if (note.mustPress)
1542-
// event = scripts.event("onPlayerHit", EventManager.get(NoteHitEvent).recycle(note, [boyfriend], true, note.noteType, note.strumID, note.noteData > 0 ? 0.023 : 0.004, score, note.animSuffix, daRating, note.isSustainNote ? null : accuracy, "game/score/", ''));
1543-
event = scripts.event("onPlayerHit", EventManager.get(NoteHitEvent).recycle(false, !note.isSustainNote, !note.isSustainNote, note, [boyfriend], true, note.noteType, "", "game/score/", "", note.strumID, score, note.isSustainNote ? null : accuracy, note.noteData > 0 ? 0.023 : 0.004, daRating, daRating == "sick"));
1540+
event = scripts.event("onPlayerHit", EventManager.get(NoteHitEvent).recycle(false, !note.isSustainNote, !note.isSustainNote, note, [boyfriend], true, note.noteType, "", "game/score/", "", note.strumID, score, note.isSustainNote ? null : accuracy, note.noteData > 0 ? 0.023 : 0.004, daRating, !note.isSustainNote && daRating == "sick"));
15441541
else
15451542
event = scripts.event("onDadHit", EventManager.get(NoteHitEvent).recycle(false, false, false, note, [dad], false, note.noteType, "", "game/score/", "", note.strumID, 0, null, 0, daRating, false));
15461543

0 commit comments

Comments
 (0)