Fixed errors with log handling and tickrate

Author: Nathan Lee

pyrunner/core/config.py

@@ -164,8 +164,6 @@ def __setitem__(self, key, value):
           self._attr[key]['value'] = True
         else:
           self._attr[key]['value'] = self._attr[key]['type'](value)
-      elif key == 'tickrate' and value < 1:
-        self._attr['tickrate']['value'] = 1
       else:
         self._attr[key]['value'] = self._attr[key]['type'](value)
 

pyrunner/core/engine.py

@@ -49,7 +49,7 @@ def initiate(self, **kwargs):
     signal_handler = SignalHandler(self.config)
     sys.path.append(self.config['worker_dir'])
     self.start_time = time.time()
-    wait_interval = 1.0/self.config['tickrate'] if self.config['tickrate'] > 0 else 0
+    wait_interval = 1.0/self.config['tickrate'] if self.config['tickrate'] >= 1 else 0
     last_save = 0
     ab_code = 0
 

pyrunner/core/node.py

@@ -131,7 +131,7 @@ def poll(self, wait=False):
           logger.restart_message(self._attempts)
           self._retcode.value = -1
 
-    return self.retcode if not running or wait else None
+    return self.retcode if (not running or wait) else None
 
   def terminate(self):
     if self._thread.is_alive():

pyrunner/worker/abstract.py

@@ -57,8 +57,9 @@ def protected_run(self):
     methods, if defined.
     """
 
-    sys.stdout = open(self.logfile, 'a')
-    sys.stderr = open(self.logfile, 'a')
+    if self.logfile:
+      sys.stdout = open(self.logfile, 'a')
+      sys.stderr = open(self.logfile, 'a')
 
     # RUN
     try:
@@ -83,7 +84,7 @@ def protected_run(self):
     else:
       # ON FAIL
       try:
-        self.retcode = self.on_fail() or self.retcode
+        self.on_fail() or self.retcode
       except NotImplementedError:
         pass
       except Exception as e: