Extend onboard/offboard scripts to update lab-manual (Phase 4)

- onboard_member.py now calls add_member_to_lab_manual() after CV update
- offboard_member.py now calls move_member_to_alumni() after CV update
- Both wrap lab-manual operations in try/except for graceful degradation
- Lab-manual changes are committed and pushed directly to master
- 192 tests passing

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: jeremymanning

scripts/offboard_member.py

@@ -266,6 +266,26 @@ def offboard_member(
     move_to_alumni(xlsx_path, member, years_string)
     update_cv_entry(cv_path, member["name"], end_year)
 
+    # Update lab-manual (best-effort; failure doesn't block offboarding)
+    try:
+        from parse_lab_manual import move_member_to_alumni as lm_move, commit_and_push_lab_manual
+        lab_manual_tex = project_root / 'lab-manual' / 'lab_manual.tex'
+        if lab_manual_tex.exists():
+            print("  Updating lab-manual...")
+            lm_move(lab_manual_tex, member["name"], end_year)
+            try:
+                commit_and_push_lab_manual(
+                    project_root / 'lab-manual',
+                    f"Offboard {member['name']}"
+                )
+                print(f"  Updated lab-manual and pushed to remote")
+            except RuntimeError as e:
+                print(f"  WARNING: Lab-manual updated locally but push failed: {e}")
+        else:
+            print("  NOTE: Lab-manual submodule not found, skipping lab-manual update")
+    except Exception as e:
+        print(f"  WARNING: Could not update lab-manual: {e}")
+
     print(f"\nSuccessfully offboarded {member['name']}")
     print("Run 'python build.py' to rebuild people.html")
 

scripts/onboard_member.py

@@ -1067,6 +1067,26 @@ def onboard_member(
     print("\nUpdating CV...")
     add_to_cv(cv_path, name, rank, current_year)
 
+    # Update lab-manual (best-effort; failure doesn't block onboarding)
+    try:
+        from parse_lab_manual import add_member_to_lab_manual, commit_and_push_lab_manual
+        lab_manual_tex = project_root / 'lab-manual' / 'lab_manual.tex'
+        if lab_manual_tex.exists():
+            print("\nUpdating lab-manual...")
+            add_member_to_lab_manual(lab_manual_tex, name, rank, current_year)
+            try:
+                commit_and_push_lab_manual(
+                    project_root / 'lab-manual',
+                    f"Onboard {name}"
+                )
+                print(f"  Updated lab-manual and pushed to remote")
+            except RuntimeError as e:
+                print(f"  WARNING: Lab-manual updated locally but push failed: {e}")
+        else:
+            print("  NOTE: Lab-manual submodule not found, skipping lab-manual update")
+    except Exception as e:
+        print(f"  WARNING: Could not update lab-manual: {e}")
+
     if github_username:
         invite_to_github_org(github_username, github_teams)
 

specs/001-people-labmanual-sync/tasks.md

@@ -73,11 +73,11 @@
 
 ### Implementation for User Story 2
 
-- [ ] T021 [US2] Refactor T017's lab_manual.tex writer into shared helper `add_member_to_lab_manual(tex_path, name, role, start_year)` in `scripts/parse_lab_manual.py` (depends on T017). Inserts `\item Name (YYYY -- )` into correct `\newthought{Role}` section under `\subsection{Current lab members}`
-- [ ] T022 [US2] Create shared helper function in `scripts/parse_lab_manual.py`: `move_member_to_alumni(tex_path, name, end_year)` that moves entry from Current to Alumni section and closes the year range
-- [ ] T023 [US2] Update `scripts/onboard_member.py`: after existing people.xlsx + JRM_CV.tex updates, call `add_member_to_lab_manual()` and `commit_and_push_lab_manual()` (from T009a), wrapped in try/except with warning on failure
-- [ ] T024 [US2] Update `scripts/offboard_member.py`: after existing people.xlsx + JRM_CV.tex updates, call `move_member_to_alumni()` and `commit_and_push_lab_manual()` (from T009a), wrapped in try/except with warning on failure
-- [ ] T025 [P] [US2] Add tests to `tests/test_parse_lab_manual.py` for: add_member_to_lab_manual (correct section, correct format), move_member_to_alumni (removal + insertion)
+- [x] T021 [US2] Refactor T017's lab_manual.tex writer into shared helper `add_member_to_lab_manual(tex_path, name, role, start_year)` in `scripts/parse_lab_manual.py` (depends on T017). Inserts `\item Name (YYYY -- )` into correct `\newthought{Role}` section under `\subsection{Current lab members}`
+- [x] T022 [US2] Create shared helper function in `scripts/parse_lab_manual.py`: `move_member_to_alumni(tex_path, name, end_year)` that moves entry from Current to Alumni section and closes the year range
+- [x] T023 [US2] Update `scripts/onboard_member.py`: after existing people.xlsx + JRM_CV.tex updates, call `add_member_to_lab_manual()` and `commit_and_push_lab_manual()` (from T009a), wrapped in try/except with warning on failure
+- [x] T024 [US2] Update `scripts/offboard_member.py`: after existing people.xlsx + JRM_CV.tex updates, call `move_member_to_alumni()` and `commit_and_push_lab_manual()` (from T009a), wrapped in try/except with warning on failure
+- [x] T025 [P] [US2] Add tests to `tests/test_parse_lab_manual.py` for: add_member_to_lab_manual (correct section, correct format), move_member_to_alumni (removal + insertion)
 
 **Checkpoint**: Onboard/offboard scripts update all three destinations; lab-manual failures warn but don't block