Rename the function that sets pgBackRest parameters in Postgres

Author: cbandy

internal/controller/postgrescluster/postgres.go

@@ -131,7 +131,7 @@ func (*Reconciler) generatePostgresParameters(
 ) *postgres.ParameterSet {
 	builtin := postgres.NewParameters()
 	pgaudit.PostgreSQLParameters(&builtin)
-	pgbackrest.PostgreSQL(cluster, &builtin, backupsSpecFound)
+	pgbackrest.PostgreSQLParameters(cluster, &builtin, backupsSpecFound)
 	pgmonitor.PostgreSQLParameters(ctx, cluster, &builtin)
 	postgres.SetHugePages(cluster, &builtin)
 

internal/pgbackrest/postgres.go

@@ -11,8 +11,8 @@ import (
 	"github.com/crunchydata/postgres-operator/pkg/apis/postgres-operator.crunchydata.com/v1beta1"
 )
 
-// PostgreSQL populates outParameters with any settings needed to run pgBackRest.
-func PostgreSQL(
+// PostgreSQLParameters populates outParameters with any settings needed to run pgBackRest.
+func PostgreSQLParameters(
 	inCluster *v1beta1.PostgresCluster,
 	outParameters *postgres.Parameters,
 	backupsEnabled bool,

internal/pgbackrest/postgres_test.go

@@ -17,7 +17,7 @@ func TestPostgreSQLParameters(t *testing.T) {
 	cluster := new(v1beta1.PostgresCluster)
 	parameters := new(postgres.Parameters)
 
-	PostgreSQL(cluster, parameters, true)
+	PostgreSQLParameters(cluster, parameters, true)
 	assert.DeepEqual(t, parameters.Mandatory.AsMap(), map[string]string{
 		"archive_mode":    "on",
 		"archive_command": `pgbackrest --stanza=db archive-push "%p"`,
@@ -28,7 +28,7 @@ func TestPostgreSQLParameters(t *testing.T) {
 		"archive_timeout": "60s",
 	})
 
-	PostgreSQL(cluster, parameters, false)
+	PostgreSQLParameters(cluster, parameters, false)
 	assert.DeepEqual(t, parameters.Mandatory.AsMap(), map[string]string{
 		"archive_mode":    "on",
 		"archive_command": "true",
@@ -40,7 +40,7 @@ func TestPostgreSQLParameters(t *testing.T) {
 		RepoName: "repo99",
 	}
 
-	PostgreSQL(cluster, parameters, true)
+	PostgreSQLParameters(cluster, parameters, true)
 	assert.DeepEqual(t, parameters.Mandatory.AsMap(), map[string]string{
 		"archive_mode":    "on",
 		"archive_command": `pgbackrest --stanza=db archive-push "%p"`,