fixed extra allocations when doing string test against alphabet.

Author: Crypt32

Asn1Parser/Universal/Asn1BitString.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Linq;
 using System.Text;
 
 namespace SysadminsLV.Asn1Parser.Universal;
@@ -20,7 +19,7 @@ public sealed class Asn1BitString : Asn1Universal {
     /// </exception>
     public Asn1BitString(Asn1Reader asn) : base(asn, TYPE) {
         UnusedBits = asn[asn.PayloadStartOffset];
-        Value = asn.GetPayload().Skip(1).ToArray();
+        Value = asn.GetPayloadAsMemory().Slice(1).ToArray();
     }
     /// <summary>
     /// Initializes a new instance of <strong>Asn1BitString</strong> from an ASN.1-encoded memory buffer.

Asn1Parser/Universal/Asn1IA5String.cs

@@ -57,9 +57,12 @@ void m_encode(String inputString) {
         Initialize(Asn1Utils.EncodeAsReader(Encoding.ASCII.GetBytes(inputString).AsSpan(), TYPE));
     }
     void m_decode(Asn1Reader asn) {
-        if (asn.GetPayload().Any(b => b > 127)) {
-            throw new InvalidDataException(String.Format(InvalidType, TYPE.ToString()));
+        ReadOnlySpan<Byte> payload = asn.GetPayloadAsMemory().Span;
+        foreach (Byte b in payload) {
+            if (b > 127) {
+                throw new InvalidDataException(String.Format(InvalidType, TYPE.ToString()));
+            }
         }
-        Value = Encoding.ASCII.GetString(asn.GetPayloadAsMemory());
+        Value = Encoding.ASCII.GetString(payload);
     }
 }

Asn1Parser/Universal/Asn1NumericString.cs

@@ -57,9 +57,12 @@ void m_encode(String inputString) {
         Initialize(Asn1Utils.EncodeAsReader(Encoding.ASCII.GetBytes(inputString).AsSpan(), TYPE));
     }
     void m_decode(Asn1Reader asn) {
-        if (asn.GetPayload().Any(b => b is < 48 or > 57 && b != 32)) {
-            throw new InvalidDataException(String.Format(InvalidType, TYPE.ToString()));
+        ReadOnlySpan<Byte> payload = asn.GetPayloadAsMemory().Span;
+        foreach (Byte b in payload) {
+            if (b is < 48 or > 57 && b != 32) {
+                throw new InvalidDataException(String.Format(InvalidType, TYPE.ToString()));
+            }
         }
-        Value = Encoding.ASCII.GetString(asn.GetPayloadAsMemory());
+        Value = Encoding.ASCII.GetString(payload);
     }
 }

Asn1Parser/Universal/Asn1PrintableString.cs

@@ -59,19 +59,25 @@ void m_encode(String inputString) {
         Initialize(Asn1Utils.EncodeAsReader(Encoding.ASCII.GetBytes(inputString).AsSpan(), TYPE));
     }
     void m_decode(Asn1Reader asn) {
-        if (!testValue(asn.GetPayload())) {
+        ReadOnlySpan<Byte> payload = asn.GetPayloadAsMemory().Span;
+        if (!testValue(payload)) {
             throw new InvalidDataException(String.Format(InvalidType, TYPE.ToString()));
         }
-        Value = Encoding.ASCII.GetString(asn.GetPayloadAsMemory());
+        Value = Encoding.ASCII.GetString(payload);
     }
     static Boolean testValue(String str) {
         List<Byte> alphabet = StringUtils.GetAlphabet(TYPE);
         try {
             return str.All(c => alphabet.Contains(Convert.ToByte(c)));
         } catch { return false; }
     }
-    static Boolean testValue(IEnumerable<Byte> rawData) {
+    static Boolean testValue(ReadOnlySpan<Byte> rawData) {
         List<Byte> alphabet = StringUtils.GetAlphabet(TYPE);
-        return rawData.All(alphabet.Contains);
+        foreach (Byte b in rawData) {
+            if (!alphabet.Contains(b)) {
+                return false;
+            }
+        }
+        return true;
     }
 }

Asn1Parser/Universal/Asn1UTF8String.cs

@@ -57,7 +57,7 @@ void m_encode(String inputString) {
         Initialize(Asn1Utils.EncodeAsReader(Encoding.UTF8.GetBytes(inputString).AsMemory().Span, TYPE));
     }
     void m_decode(Asn1Reader asn) {
-        Value = Encoding.UTF8.GetString(asn.GetPayloadAsMemory());
+        Value = Encoding.UTF8.GetString(asn.GetPayloadAsMemory().Span);
     }
     static Boolean testValue(String str) {
         return str.All(x => Convert.ToUInt32(x) <= 255);

Asn1Parser/Utils/CLRExtensions/EncodingExtensions.cs

@@ -14,9 +14,9 @@ static class EncodingExtensions {
     /// <param name="bytes">The byte sequence to decode, represented as a <see cref="ReadOnlyMemory{T}"/> of <see cref="Byte"/>.</param>
     /// <returns>A <see cref="String"/> that contains the decoded characters from the byte sequence.</returns>
     /// <exception cref="ArgumentNullException">Thrown if <paramref name="encoding"/> is <c>null</c>.</exception>
-    public static String GetString(this Encoding encoding, ReadOnlyMemory<Byte> bytes) {
+    public static String GetString(this Encoding encoding, ReadOnlySpan<Byte> bytes) {
 #if NET8_0_OR_GREATER
-        return encoding.GetString(bytes.Span);
+        return encoding.GetString(bytes);
 #else
         return encoding.GetString(bytes.ToArray());
 #endif