Skip to content

Commit b9a4196

Browse files
committed
unique id refactoring
1 parent cc62e8d commit b9a4196

5 files changed

Lines changed: 9 additions & 8 deletions

File tree

java/src/main/java/com/cybersource/ws/client/Client.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ private static Document soapWrapAndSign(
210210
if (!logSignedData) {
211211
logger.log(
212212
Logger.LT_REQUEST,
213-
"UUID > "+(logger.getUniqueKey()).toString() + "\n" +
213+
"UUID > "+(logger.getUniqueKey()) + "\n" +
214214
"Input request is" + "\n" +
215215
"======================================= \n"
216216
+ mapToString(request, true, PCI.REQUEST));

java/src/main/java/com/cybersource/ws/client/HttpClientConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ public boolean retryMethod(
255255
// if it's OK to retry methods that have been sent
256256
try {
257257
Thread.sleep(retryWaitInterval);
258-
logger.log( Logger.LT_INFO, " Retrying Request -- "+logger.getUniqueKey().toString()+ " Retry Count -- "+executionCount);
258+
logger.log( Logger.LT_INFO, " Retrying Request -- "+logger.getUniqueKey()+ " Retry Count -- "+executionCount);
259259
} catch (InterruptedException e) {
260260
e.printStackTrace();
261261
}

java/src/main/java/com/cybersource/ws/client/LoggerWrapper.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
public class LoggerWrapper implements Logger {
3030
private Logger logger = null;
3131
private MyStopWatch stopWatch = new MyStopWatch();
32-
private UUID uniqueKey=UUID.randomUUID();
33-
32+
private UUID uniqueKey;
33+
3434
/**
3535
* Constructor.
3636
*
@@ -52,6 +52,7 @@ public LoggerWrapper(
5252
MerchantConfig mc = _mc;
5353
boolean prepare = false;
5454
boolean logTranStart = false;
55+
uniqueKey = UUID.randomUUID();
5556

5657
if (_logger != null) {
5758
logger = _logger;
@@ -79,8 +80,8 @@ public LoggerWrapper(
7980
* Getter method for uniqueKey
8081
* @return UUID
8182
*/
82-
public UUID getUniqueKey() {
83-
return uniqueKey;
83+
public String getUniqueKey() {
84+
return uniqueKey!=null ? uniqueKey.toString():null;
8485
}
8586

8687
/**

java/src/main/java/com/cybersource/ws/client/XMLClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ private static Document soapWrapAndSign(
368368

369369
if (!logSignedData) {
370370
logger.log(Logger.LT_REQUEST,
371-
"UUID > "+(logger.getUniqueKey()).toString() + "\n" +
371+
"UUID > "+(logger.getUniqueKey()) + "\n" +
372372
"Input request is" + "\n" +
373373
"======================================= \n"
374374
+ Utility.nodeToString(doc, PCI.REQUEST));

java/src/test/java/com/cybersource/ws/client/CustomHttpConnectionClass.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ public boolean retryMethod(
171171
// if it's OK to retry methods that have been sent
172172
try {
173173
Thread.sleep(retryWaitInterval);
174-
logger.log( Logger.LT_INFO," Retrying Request -- " +logger.getUniqueKey().toString()+ " Retry Count -- "+executionCount);
174+
logger.log( Logger.LT_INFO," Retrying Request -- " +logger.getUniqueKey()+ " Retry Count -- "+executionCount);
175175
} catch (InterruptedException e) {
176176
// TODO Auto-generated catch block
177177
e.printStackTrace();

0 commit comments

Comments
 (0)