Skip to content

Commit e917579

Browse files
Placed the Request headers before execute method
1 parent 30f5ae8 commit e917579

2 files changed

Lines changed: 12 additions & 27 deletions

File tree

java/src/main/java/com/cybersource/ws/client/Connection.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,8 @@ private void checkForFault()
124124
throws FaultException, ClientException {
125125
try {
126126
logger.log(Logger.LT_INFO, "Reading response...");
127-
128127
int responseCode = getHttpResponseCode();
129-
130128
logResponseHeaders();
131-
132129
// if successful, there's nothing left to do here.
133130
// we'll process the response in a later method.
134131
if (responseCode == HttpURLConnection.HTTP_OK) return;

java/src/main/java/com/cybersource/ws/client/HttpClientConnection.java

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.apache.commons.httpclient.params.HttpConnectionManagerParams;
2727
import org.apache.commons.httpclient.params.HttpMethodParams;
2828
import org.w3c.dom.Document;
29-
3029
import javax.xml.parsers.DocumentBuilder;
3130
import javax.xml.transform.TransformerConfigurationException;
3231
import javax.xml.transform.TransformerException;
@@ -37,12 +36,10 @@
3736
import java.net.ProtocolException;
3837
import java.util.ArrayList;
3938
import java.util.List;
40-
import java.util.HashMap;
4139
import java.util.List;
42-
import java.util.Map;
43-
import java.util.Map.Entry;
4440
import org.apache.commons.httpclient.Header;
45-
41+
import java.util.ArrayList;
42+
import java.util.Arrays;
4643
/**
4744
* Class helps in posting the Request document for the Transaction using HttpClient.
4845
* Converts the document to String format and also helps in setting up the Proxy connections.
@@ -86,9 +83,9 @@ void postDocument(Document request)
8683

8784
postMethod.setRequestEntity(
8885
new StringRequestEntity(requestString, null, "UTF-8"));
89-
httpClient.executeMethod(postMethod);
90-
postMethod.setRequestHeader("v-c-origin-iat", String.valueOf(System.currentTimeMillis()));
86+
postMethod.setRequestHeader("v-c-origin-iat", String.valueOf(System.currentTimeMillis()));
9187
logRequestHeaders();
88+
httpClient.executeMethod(postMethod);
9289
}
9390

9491
/* (non-Javadoc)
@@ -238,26 +235,17 @@ public boolean retryMethod(
238235
}
239236
}
240237

241-
@Override
242-
void logRequestHeaders() {
243-
Header[] headers=postMethod.getRequestHeaders();
244-
Map<String, String> headerMap = new HashMap<String, String>();
245-
for(Header header:headers){
246-
headerMap.put(header.getName(), header.getValue());
247-
}
248-
logger.log(Logger.LT_INFO, "Request Headers: " + headerMap);
249-
}
238+
@Override
239+
void logRequestHeaders() {
240+
List<Header> reqheaders=Arrays.asList(postMethod.getRequestHeaders());
241+
logger.log(Logger.LT_INFO, "Request Headers: " +reqheaders);
242+
}
250243

251244
@Override
252245
public void logResponseHeaders() {
253-
Header[] headers = postMethod.getResponseHeaders();
254-
Map<String, String> headerMap = new HashMap<String, String>();
255-
for(Header header: headers){
256-
headerMap.put(header.getName(), header.getValue());
257-
}
258-
259-
logger.log(Logger.LT_INFO, "Response Headers:" +headerMap);
260-
}
246+
List<Header> respheaders=Arrays.asList(postMethod.getResponseHeaders());
247+
logger.log(Logger.LT_INFO, "Response Headers"+ respheaders);
248+
}
261249

262250
}
263251

0 commit comments

Comments
 (0)