Skip to content

Commit fc4d297

Browse files
committed
changed the SecurityUtil and Identity file after first code review
1 parent 6efa205 commit fc4d297

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

java/src/main/java/com/cybersource/ws/client/Identity.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ public class Identity {
4141

4242
private static final String SERVER_ALIAS = "CyberSource_SJC_US";
4343

44-
Logger logger;
44+
Logger logger = new LoggerImpl(merchantConfig);
45+
46+
4547

4648

4749

@@ -103,6 +105,7 @@ public Identity(MerchantConfig merchantConfig,X509Certificate x509Certificate, P
103105
try {
104106
this.lastModifiedDate=merchantConfig.getKeyFile().lastModified();
105107
} catch (ConfigException e) {
108+
106109
logger.log(Logger.LT_EXCEPTION,
107110
"Identity object ,cannot instantiate with key file lastModifiedDate. "
108111
+ e.getMessage());

java/src/main/java/com/cybersource/ws/client/SecurityUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ public static void loadMerchantP12File(MerchantConfig merchantConfig, Logger log
8686

8787

8888

89-
Identity identitys=identities.get(merchantConfig.getMerchantID());
90-
if(identities.get(merchantConfig.getMerchantID()) == null || !(identitys.isValid(merchantConfig.getKeyFile()))){
89+
Identity identity=identities.get(merchantConfig.getMerchantID());
90+
if(identity == null || !(identity.isValid(merchantConfig.getKeyFile()))){
9191
try {
9292
if (localKeyStoreHandler == null)
9393
initKeystore();

0 commit comments

Comments
 (0)